Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: net/http/http_util.cc

Issue 11192045: Process only the first Strict-Transport-Security header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_util.cc
===================================================================
--- net/http/http_util.cc (revision 161880)
+++ net/http/http_util.cc (working copy)
@@ -392,7 +392,11 @@
// The format of auth-challenges mixes both space separated tokens and
// comma separated properties, so coalescing on comma won't work.
"www-authenticate",
- "proxy-authenticate"
+ "proxy-authenticate",
+ // Perhaps incorrectly, Strict-Transport-Security specifies that UAs not
+ // process any STS headers after the first one. To enforce this, we must
+ // declare it non-coalescing.
Ryan Sleevi 2012/10/18 19:45:34 comment nit: A nit I inherited from mark@, which i
palmer 2012/10/18 21:01:58 Done.
+ "strict-transport-security"
};
for (size_t i = 0; i < arraysize(kNonCoalescingHeaders); ++i) {
if (LowerCaseEqualsASCII(name_begin, name_end, kNonCoalescingHeaders[i]))

Powered by Google App Engine
This is Rietveld 408576698