Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 11192036: Fix for Visual Studio prompting for $(CHROME_PATH) (Closed)

Created:
8 years, 2 months ago by Sam Clegg
Modified:
8 years, 2 months ago
Reviewers:
noelallen1, binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Fix for Visual Studio prompting for $(CHROME_PATH). We need to make sure that the expanded version of $(CHROME_PATH) is always used, otherwise Visual Studio will complain, so we expand this variable on within the "LocalDebuggerCommand" as part of the project modifications that we do when NaCl/PPAPI are first added to the project. The problem is that the "LocalDebuggerCommand" is stored not in the project itself but in the .user file. This change means that even if the user deletes that .user file (or more likely receives a project files without an accompanying .user file) we detect that $(CHROME_PATH) is within "LocalDebuggerCommand" and force an update to the settings at that time. BUG=155094 Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/hello_world_gles.vcxproj.user View 1 chunk +0 lines, -8 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs View 2 chunks +9 lines, -3 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/ProjectSettingsTest.cs View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Sam Clegg
8 years, 2 months ago (2012-10-17 18:44:08 UTC) #1
binji
Can you explain what's happening here? The bug and the description aren't making it clear ...
8 years, 2 months ago (2012-10-17 18:50:50 UTC) #2
Sam Clegg
8 years, 2 months ago (2012-10-17 19:05:05 UTC) #3
binji
8 years, 2 months ago (2012-10-17 19:08:06 UTC) #4
ok, lgtm

Powered by Google App Engine
This is Rietveld 408576698