Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: chromeos/dbus/shill_service_client.cc

Issue 11192024: Add chromeos::NetworkStateManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase with dbus tests in trunk Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/shill_service_client.cc
diff --git a/chromeos/dbus/shill_service_client.cc b/chromeos/dbus/shill_service_client.cc
index f208966ab3b6b690177fa801e720597a898cb630..3839050a1c5a8f5eb8358ff91231a80d69c6c978 100644
--- a/chromeos/dbus/shill_service_client.cc
+++ b/chromeos/dbus/shill_service_client.cc
@@ -291,8 +291,7 @@ class ShillServiceClientStubImpl : public ShillServiceClient,
virtual void AddService(const std::string& service_path,
const std::string& name,
const std::string& type,
- const std::string& state,
- const std::string& security) OVERRIDE {
+ const std::string& state) OVERRIDE {
base::DictionaryValue* properties = GetServiceProperties(service_path);
properties->SetWithoutPathExpansion(
flimflam::kSSIDProperty,
@@ -306,9 +305,6 @@ class ShillServiceClientStubImpl : public ShillServiceClient,
properties->SetWithoutPathExpansion(
flimflam::kStateProperty,
base::Value::CreateStringValue(state));
- properties->SetWithoutPathExpansion(
- flimflam::kSecurityProperty,
- base::Value::CreateStringValue(security));
}
virtual void RemoveService(const std::string& service_path) {
@@ -319,7 +315,8 @@ class ShillServiceClientStubImpl : public ShillServiceClient,
const std::string& property,
const base::Value& value) OVERRIDE {
SetProperty(dbus::ObjectPath(service_path), property, value,
- base::Bind(&base::DoNothing), ErrorCallback());
+ base::Bind(&base::DoNothing),
+ base::Bind(&ShillServiceClientStubImpl::ErrorFunction));
}
virtual void ClearServices() OVERRIDE {
@@ -331,20 +328,23 @@ class ShillServiceClientStubImpl : public ShillServiceClient,
// Add stub services. Note: names match Manager stub impl.
AddService("stub_ethernet", "eth0",
flimflam::kTypeEthernet,
- flimflam::kStateOnline,
- flimflam::kSecurityNone);
+ flimflam::kStateOnline);
+
AddService("stub_wifi1", "wifi1",
flimflam::kTypeWifi,
- flimflam::kStateOnline,
- flimflam::kSecurityNone);
+ flimflam::kStateOnline);
+
AddService("stub_wifi2", "wifi2_PSK",
flimflam::kTypeWifi,
- flimflam::kStateIdle,
- flimflam::kSecurityPsk);
+ flimflam::kStateIdle);
+ base::StringValue psk_value(flimflam::kSecurityPsk);
+ SetServiceProperty("stub_wifi2",
+ flimflam::kSecurityProperty,
+ psk_value);
+
AddService("stub_cellular1", "cellular1",
flimflam::kTypeCellular,
- flimflam::kStateIdle,
- flimflam::kSecurityNone);
+ flimflam::kStateIdle);
base::StringValue technology_value(flimflam::kNetworkTechnologyGsm);
SetServiceProperty("stub_cellular1",
flimflam::kNetworkTechnologyProperty,
@@ -392,6 +392,10 @@ class ShillServiceClientStubImpl : public ShillServiceClient,
return properties;
}
+ static void ErrorFunction(const std::string& error_name,
+ const std::string& error_message) {
+ LOG(ERROR) << "Shill Error: " << error_name << " : " << error_message;
+ }
base::DictionaryValue stub_services_;
ObserverList<ShillPropertyChangedObserver> observer_list_;

Powered by Google App Engine
This is Rietveld 408576698