Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: Platform/chromium/public/WebFileSystem.h

Issue 11192017: ********** WebCore blob hacking (Closed) Base URL: http://svn.webkit.org/repository/webkit/trunk/Source/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Platform/chromium/public/WebBlobRegistry.h ('k') | Platform/chromium/public/WebHTTPBody.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Platform/chromium/public/WebFileSystem.h
===================================================================
--- Platform/chromium/public/WebFileSystem.h (revision 140218)
+++ Platform/chromium/public/WebFileSystem.h (working copy)
@@ -120,14 +120,14 @@
// This is a fast, synchronous call, and should not stat the filesystem.
virtual WebFileWriter* createFileWriter(const WebURL& path, WebFileWriterClient*) { WEBKIT_ASSERT_NOT_REACHED(); return 0; }
- // Creates a snapshot file for a given file specified by |path| and registers the file with the |blobURL|. It returns the metadata of the created snapshot file.
+ // Creates a snapshot file for a given file specified by |path|. It returns the metadata of the created snapshot file.
// The returned metadata should include a local platform path to the snapshot image.
// In local filesystem cases the backend may simply return the metadata of the file itself (as well as readMetadata does), while in remote filesystem case the backend may download the file into a temporary snapshot file and return the metadata of the temporary file.
// The returned metadata is used to create a File object for the |path|.
- // The snapshot file is supposed to be deleted when the last reference to the |blobURL| is dropped.
- // WebFileSystemCallbacks::didReadMetadata() with the metadata of the snapshot file must be called when the operation is completed successfully.
+ // The snapshot file is supposed to be deleted when the last reference to a WebCore::File referring to it's path is dropped.
+ // WebFileSystemCallbacks::didCreateSnapshotFile() with the metadata of the snapshot file must be called when the operation is completed successfully.
// WebFileSystemCallbacks::didFail() must be called otherwise.
- virtual void createSnapshotFileAndReadMetadata(const WebURL& blobURL, const WebURL& path, WebFileSystemCallbacks*) { WEBKIT_ASSERT_NOT_REACHED(); }
+ virtual void createSnapshotFileAndReadMetadata(const WebURL& path, WebFileSystemCallbacks*) { WEBKIT_ASSERT_NOT_REACHED(); }
protected:
virtual ~WebFileSystem() { }
« no previous file with comments | « Platform/chromium/public/WebBlobRegistry.h ('k') | Platform/chromium/public/WebHTTPBody.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698