Issue 11192014: Revert 162252 - Make Web Intents picker in Views conform to latest mocks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11192014: Revert 162252 - Make Web Intents picker in Views conform to latest mocks (Closed)

Created:
8 years, 2 months ago by ericu

Modified:
8 years, 2 months ago

Reviewers:
please use gerrit instead

CC:
chromium-reviews, groby+watch_chromium.org, tfarina, Aaron Boodman, mihaip-chromium-reviews_chromium.org, gbillock+watch_chromium.org, smckay+watch_chromium.org, rouslan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 162252 - Make Web Intents picker in Views conform to latest mocks BUG=148615 Review URL: https://chromiumcodereview.appspot.com/11044020 TBR=rouslan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162256

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+585 lines, -735 lines)			Patch
M	chrome/app/generated_resources.grd	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/constrained_window_constants.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_model.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_model.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/views/collected_cookies_views.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/constrained_window_frame_simple.h	View	3 chunks	+27 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/constrained_window_frame_simple.cc	View	2 chunks	+148 lines, -78 lines	0 comments	Download
M	chrome/browser/ui/views/constrained_window_views.h	View	4 chunks	+7 lines, -29 lines	0 comments	Download
M	chrome/browser/ui/views/constrained_window_views.cc	View	13 chunks	+66 lines, -53 lines	0 comments	Download
M	chrome/browser/ui/views/constrained_window_views_browsertest.cc	View	3 chunks	+6 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/login_prompt_views.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/views/ssl_client_certificate_selector.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/web_intent_picker_views.cc	View	27 chunks	+308 lines, -515 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages