Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 11192013: Added help text to PeerConnection test page. (Closed)

Created:
8 years, 2 months ago by phoglund_chromium
Modified:
8 years, 2 months ago
Reviewers:
tnakamura, Nirnimesh
CC:
chromium-reviews
Visibility:
Public.

Description

Added help text to PeerConnection test page. BUG= NOTRY=True Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162289

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -0 lines) Patch
M chrome/test/data/webrtc/manual/peerconnection.html View 1 1 chunk +71 lines, -0 lines 0 comments Download
M chrome/test/data/webrtc/manual/peerconnection.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
phoglund_chromium
Ted, have a look at the new help text and see if we need anything ...
8 years, 2 months ago (2012-10-16 21:21:58 UTC) #1
Nirnimesh
LGTM
8 years, 2 months ago (2012-10-16 21:34:31 UTC) #2
tnakamura
lgtm Thanks for jumping on this so quickly! I just have a few minor requests. ...
8 years, 2 months ago (2012-10-16 21:45:54 UTC) #3
phoglund_chromium
PTAL https://codereview.chromium.org/11192013/diff/1/chrome/test/data/webrtc/manual/peerconnection.html File chrome/test/data/webrtc/manual/peerconnection.html (right): https://codereview.chromium.org/11192013/diff/1/chrome/test/data/webrtc/manual/peerconnection.html#newcode146 chrome/test/data/webrtc/manual/peerconnection.html:146: attempt to stop or remove the previous stream ...
8 years, 2 months ago (2012-10-16 22:47:03 UTC) #4
tnakamura
lgtm
8 years, 2 months ago (2012-10-16 23:05:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/11192013/6001
8 years, 2 months ago (2012-10-17 00:18:24 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-17 00:32:18 UTC) #7
Change committed as 162289

Powered by Google App Engine
This is Rietveld 408576698