Issue 1119173003: win: pull in string_util_win.h from Chromium for strcasecmp

Issue 1119173003: win: pull in string_util_win.h from Chromium for strcasecmp (Closed)

Created:
5 years, 7 months ago by scottmg

Modified:
5 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/mini_chromium@master

Target Ref:
refs/heads/master

Project:
mini_chromium

Visibility:
Public.

More Reviews

Description

win: pull in string_util_win.h from Chromium for strcasecmp R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/chromium/mini_chromium/+/1554c70b02e512412e163b7d823bdd08f6867c05

Patch Set 2 : cleanup #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -1 line)			Patch
M	base/base.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	base/strings/string_util.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
A	base/strings/string_util_win.h	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM. The Crashpad-esque way to do this would be to put it in compat/win, but ...

5 years, 7 months ago (2015-05-04 20:50:13 UTC) #2

scottmg

https://codereview.chromium.org/1119173003/diff/1/base/strings/string_util_win.h File base/strings/string_util_win.h (right): https://codereview.chromium.org/1119173003/diff/1/base/strings/string_util_win.h#newcode8 base/strings/string_util_win.h:8: #include <stdarg.h> On 2015/05/04 20:50:13, Mark Mentovai wrote: > ...

5 years, 7 months ago (2015-05-04 21:01:09 UTC) #3

scottmg

5 years, 7 months ago (2015-05-04 21:01:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1554c70b02e512412e163b7d823bdd08f6867c05 (presubmit successful).

Expand Messages | Collapse Messages