media/filters/source_buffer_stream.h - Issue 1119163005: Return EOS when selected_range_ is NULL in SourceBufferStream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/source_buffer_stream.h

Issue 1119163005: Return EOS when selected_range_ is NULL in SourceBufferStream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge all EOS checks to single function and add unit tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/filters/source_buffer_stream.h

diff --git a/media/filters/source_buffer_stream.h b/media/filters/source_buffer_stream.h

index 8a7ac85957087c40d89d42d62a6a3453b8afdea1..c70dcf5145f2f0f6ede645ee2ce37ed57faab03b 100644

--- a/media/filters/source_buffer_stream.h

+++ b/media/filters/source_buffer_stream.h

@@ -277,7 +277,7 @@ class MEDIA_EXPORT SourceBufferStream {

// Returns true if we don't have any ranges or the last range is selected

// or there is a pending seek beyond any existing ranges.

wolenetz 2015/05/12 20:36:24 nit: Please adjust this comment, too: there are ne

- bool IsEndSelected() const;

+ bool IsEndOfStreamReached() const;

// Deletes the range pointed to by |*itr| and removes it from |ranges_|.

« no previous file with comments | « no previous file | media/filters/source_buffer_stream.cc » ('j') | media/filters/source_buffer_stream.cc » ('J')