Return EOS when selected_range_ is NULL in SourceBufferStream

media/filters/source_buffer_stream.cc

Index: media/filters/source_buffer_stream.cc
diff --git a/media/filters/source_buffer_stream.cc b/media/filters/source_buffer_stream.cc
index 4271ab9601bb44393a6f79f0db3fd09daf7c00fd..7eb21520fc5c952da7283571862413aef37dfe93 100644
--- a/media/filters/source_buffer_stream.cc
+++ b/media/filters/source_buffer_stream.cc
@@ -1099,7 +1099,7 @@ SourceBufferStream::Status SourceBufferStream::GetNextBufferInternal(
   }
 
   if (!selected_range_ || !selected_range_->HasNextBuffer()) {
-    if (end_of_stream_ && IsEndSelected())
+    if (end_of_stream_ && (!selected_range_ || IsEndSelected()))

[wolenetz, 2015/05/05 20:51:35]

Interesting. Since IsEndSelected() is only used in two places (here, and in
IsSeekPending()), ISTM that IsSeekPending() might need similar support for
!selected_range_ (&& track_buffer_.empty()).
Would refactoring IsEndSelected() to instead be IsEndOfStreamReached() (and
include conditions involving track_buffer_.empty(), !selected_range_,
end_of_stream_) make both this line and IsSeekPending() more readable?

Ideally, SourceBufferStream unit tests could demonstrate the problem here (with
at least GetNextBufferInternal(), if not also IsSeekPending()). WDYT?

[landell, 2015/05/06 08:59:53]

I agree. That is how I wanted to do it but I went for the less intrusive change
since I was unsure if this check could mess things up in the seeking case. I'll
make the change. 
I'll see if I can come up with a unit test that demonstrates this. Thanks for
the input.

[landell, 2015/05/06 10:46:53]

Done.

       return kEndOfStream;
     DVLOG(3) << __FUNCTION__ << " " << GetStreamTypeName()
              << ": returning kNeedBuffer "