components/favicon/core/favicon_handler.h - Issue 1119163003: Save large icons to a new LARGE_ICON type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/favicon_handler.h

Issue 1119163003: Save large icons to a new LARGE_ICON type Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: yet more clarifying comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/core/favicon_handler.h

diff --git a/components/favicon/core/favicon_handler.h b/components/favicon/core/favicon_handler.h

index 3fee8be7cb933e757619127df7b7830695c3e6d1..8eb4bdcba054b2396e1a0895b117cf7252595999 100644

--- a/components/favicon/core/favicon_handler.h

+++ b/components/favicon/core/favicon_handler.h

@@ -193,7 +193,7 @@ class FaviconHandler {

// Get the maximal icon size in pixels for a icon of type |icon_type| for the

// current platform.

- static int GetMaximalIconSize(favicon_base::IconType icon_type);

+ int GetMaximalIconSize(favicon_base::IconType icon_type);

// See description above class for details.

void OnFaviconDataForInitialURLFromFaviconService(const std::vector<