Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Issue 1119113004: Reland "Load and apply a vcgt table from an ICC file to the internal display" (Closed)

Created:
5 years, 7 months ago by robert.bradford
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, kalyank, oshima+watch_chromium.org, ozone-reviews_chromium.org, piman+watch_chromium.org, sadrul, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@vcgt-rebase
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Load and apply a vcgt table from an ICC file to the internal display" When the command line switch --internal-display-color-profile-file is provided load the given ICC file using qcms and extract the VCGT data. Use this VCGT data to apply a gamma ramp to change the output on the internal display using drmModeCrtcSetGammaRamp. Original CL: https://codereview.chromium.org/1028563003/ Reason for reland: Linux ChromiumOS GN (dbg) build broke (missing qcms dep in ash/BUILD.gn) BUG=471749 TEST=On a link_freon device add the command line option to load a sample ICC file (e.g. Bluish.icc to give a blue tint) and observe on startup that the internal display is blue tinted. TBR=sievers@chromium.org Committed: https://crrev.com/ab052495c02e7552aeacf7d82c28f9d72eba6564 Cr-Commit-Position: refs/heads/master@{#328514}

Patch Set 1 : Original code #

Patch Set 2 : Add third_party/qcms to ash BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+411 lines, -0 lines) Patch
M ash/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/ash.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M ash/content/display/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
A ash/content/display/display_color_manager_chromeos.h View 1 chunk +66 lines, -0 lines 0 comments Download
A ash/content/display/display_color_manager_chromeos.cc View 1 chunk +139 lines, -0 lines 0 comments Download
M ash/shell.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/shell.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/display/chromeos/display_configurator.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/display/chromeos/display_configurator.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M ui/display/chromeos/test/action_logger_util.h View 3 chunks +5 lines, -0 lines 0 comments Download
M ui/display/chromeos/test/action_logger_util.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M ui/display/chromeos/test/test_native_display_delegate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/display/chromeos/test/test_native_display_delegate.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/display/chromeos/x11/native_display_delegate_x11.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/display/chromeos/x11/native_display_delegate_x11.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/display/display.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/display/types/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A ui/display/types/gamma_ramp_rgb_entry.h View 1 chunk +23 lines, -0 lines 0 comments Download
M ui/display/types/native_display_delegate.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/ozone/common/gpu/ozone_gpu_messages.h View 3 chunks +12 lines, -0 lines 0 comments Download
M ui/ozone/common/native_display_delegate_ozone.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/ozone/common/native_display_delegate_ozone.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.cc View 2 chunks +29 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_gpu_display_manager.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_gpu_platform_support.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_gpu_platform_support.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_native_display_delegate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_native_display_delegate.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/test/mock_drm_device.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/test/mock_drm_device.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
robert.bradford
Hi folks this a reland of the CL you previously reviewed with just a change ...
5 years, 7 months ago (2015-05-05 15:30:35 UTC) #3
oshima
lgtm
5 years, 7 months ago (2015-05-05 15:36:55 UTC) #4
spang
lgtm In my experience after a revert such as this people generally reopen the old ...
5 years, 7 months ago (2015-05-05 15:39:59 UTC) #5
dcheng
ipc changes still lgtm
5 years, 7 months ago (2015-05-05 17:59:05 UTC) #6
Noel Gordon
lgtm for qcms
5 years, 7 months ago (2015-05-06 00:49:33 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119113004/20001
5 years, 7 months ago (2015-05-06 10:19:05 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-06 11:06:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119113004/20001
5 years, 7 months ago (2015-05-06 11:06:36 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-06 11:10:12 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 11:11:03 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab052495c02e7552aeacf7d82c28f9d72eba6564
Cr-Commit-Position: refs/heads/master@{#328514}

Powered by Google App Engine
This is Rietveld 408576698