bluetooth: Initial JNI setup for device/bluetooth.

device/bluetooth/bluetooth_adapter_android.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_ANDROID_H_
 #define DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_ANDROID_H_
 
+#include "base/android/jni_android.h"
 #include "base/memory/weak_ptr.h"
 #include "device/bluetooth/bluetooth_adapter.h"
 
 namespace base {
 class SequencedTaskRunner;
 }  // namespace base
 
 namespace device {
 
 // The BluetoothAdapterAndroid class implements BluetoothAdapter for the
 // Android platform.
 class DEVICE_BLUETOOTH_EXPORT BluetoothAdapterAndroid final
     : public BluetoothAdapter {
  public:
-  static base::WeakPtr<BluetoothAdapter> CreateAdapter();
+  // Create a BluetoothAdapterAndroid instance.
+  static base::WeakPtr<BluetoothAdapterAndroid> CreateAdapter();

[armansito, 2015/05/06 01:57:06]

Shouldn't this be <BluetoothAdapter>?

[scheib, 2015/05/06 04:30:15]

No, changed to BluetoothAdapterAndroid so that Android unit tests can
instantiate and test the Android implementation. The
BluetoothAdapter::CreateAdapter method returns a BluetoothAdapter (by calling
this method).

+
+  // Register C++ methods exposed to Java using JNI.
+  static bool RegisterJNI(JNIEnv* env);
+
+  // True if this app has android permissions necessary for bluetooth.

[armansito, 2015/05/06 01:57:06]

s/bluetooth/Bluetooth/

[scheib, 2015/05/06 04:30:15]

Done.

+  bool has_bluetooth_permission() { return has_bluetooth_permission_; }

[armansito, 2015/05/06 01:57:06]

nit: make this a const method.

[scheib, 2015/05/06 04:30:15]

Done.

 
   // BluetoothAdapter:
   std::string GetAddress() const override;
   std::string GetName() const override;
   void SetName(const std::string& name,
                const base::Closure& callback,
                const ErrorCallback& error_callback) override;
   bool IsInitialized() const override;
   bool IsPresent() const override;
   bool IsPowered() const override;
@@ skipping 34 matching lines @@
                            const ErrorCallback& error_callback) override;
   void RemoveDiscoverySession(BluetoothDiscoveryFilter* discovery_filter,
                               const base::Closure& callback,
                               const ErrorCallback& error_callback) override;
   void SetDiscoveryFilter(scoped_ptr<BluetoothDiscoveryFilter> discovery_filter,
                           const base::Closure& callback,
                           const ErrorCallback& error_callback) override;
   void RemovePairingDelegateInternal(
       BluetoothDevice::PairingDelegate* pairing_delegate) override;
 
+  // Java object org.chromium.device.bluetooth.BluetoothAdapter.
+  base::android::ScopedJavaGlobalRef<jobject> j_bluetooth_adapter_;
+
+  bool has_bluetooth_permission_ = false;

[armansito, 2015/05/06 01:57:06]

Is this allowed in Chromium (or C++ for that matter)? Otherwise initialize in
the constructor.

[scheib, 2015/05/06 04:30:15]

Yes, https://chromium-cpp.appspot.com/ "Non-Static Class Member Initializers".
Though, I've removed it from this patch.

   std::string address_;
   std::string name_;
 
   // Note: This should remain the last member so it'll be destroyed and
   // invalidate its weak pointers before any other members are destroyed.
   base::WeakPtrFactory<BluetoothAdapterAndroid> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BluetoothAdapterAndroid);
 };
 
 }  // namespace device
 
 #endif  // DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_ANDROID_H_