Modifications to skia.gyp for WebKit side code suppressions.

Modifications to skia.gyp for WebKit side code suppressions.

This change would be made after
https://bugs.webkit.org/show_bug.cgi?id=99759
is committed, and there is a WebKit roll into Chromium.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165005
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165199

[bungeman-chromium, 2012-10-19 02:50:49]

This is the Chromium side of the proposed change to enable suppressing Skia code
changes in WebKit.

[epoger, 2012-10-24 18:01:24]

LGTM

context:
https://docs.google.com/a/google.com/document/d/1PKzVB20IiEr6ryJr0UFHhQV2x14D...

[reed1, 2012-10-29 16:59:32]

lgtm

[commit-bot: I haz the power, 2012-10-30 20:46:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bungeman@chromium.org/11191074/8001

[bungeman-chromium, 2012-10-30 21:27:54]

So this doesn't work as-is at the moment because the Chromium iOS port doesn't
build WebKit, so it doesn't checkout Source/Webkit/chromium at all (it just
checks out Source/WebKit/chromium/public directly). However, it does use Skia,
so the iOS build breaks because we're referencing a gyp file it doesn't check
out. I'm not sure what to do about this at the moment, so I'm open to any
suggestions.

[schenney, 2012-10-30 21:34:33]

Isn't the obvious thing to just ask the Baling folks to also check out the
extra skia gyp file?
On Oct 30, 2012 5:27 PM, <bungeman@chromium.org> wrote:

> So this doesn't work as-is at the moment because the Chromium iOS port
> doesn't
> build WebKit, so it doesn't checkout Source/Webkit/chromium at all (it just
> checks out Source/WebKit/chromium/public directly). However, it does use
> Skia,
> so the iOS build breaks because we're referencing a gyp file it doesn't
> check
> out. I'm not sure what to do about this at the moment, so I'm open to any
> suggestions.
>
>
https://chromiumcodereview.**appspot.com/11191074/<https://chromiumcodereview...
>

[schenney, 2012-10-30 21:35:47]

s/Baling/Bling/

Damn Android suggest.
On Oct 30, 2012 5:34 PM, "Stephen Chenney" <schenney@google.com> wrote:

> Isn't the obvious thing to just ask the Baling folks to also check out the
> extra skia gyp file?
> On Oct 30, 2012 5:27 PM, <bungeman@chromium.org> wrote:
>
>> So this doesn't work as-is at the moment because the Chromium iOS port
>> doesn't
>> build WebKit, so it doesn't checkout Source/Webkit/chromium at all (it
>> just
>> checks out Source/WebKit/chromium/public directly). However, it does use
>> Skia,
>> so the iOS build breaks because we're referencing a gyp file it doesn't
>> check
>> out. I'm not sure what to do about this at the moment, so I'm open to any
>> suggestions.
>>
>>
https://chromiumcodereview.**appspot.com/11191074/<https://chromiumcodereview...
>>
>

[bungeman-chromium, 2012-10-31 22:55:21]

After much ado, this change is now landed. Stephen and Dirk, feel free to try a
rebaseline at your convenience.