Issue 2368: LiveEdit crashes when new object/array literal is added

test/mjsunit/debug-liveedit-literals.js

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 10 matching lines @@
 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 // Flags: --expose-debug-as debug
 // Get the Debug object exposed from the debug context global object.
 
-// In this test case we edit a script so that techincally function text
-// hasen't been changed. However actually function became one level more nested
-// and must be recompiled because it uses variable from outer scope.
-
-
 Debug = debug.Debug
 
-var function_z_text =
-"  function Z() {\n"
-+ "    return 2 + p;\n"
-+ "  }\n";
+function Test(old_expression, new_expression) {
+    eval("var t1 =1;\n" +
+         "function ChooseAnimal() {\n" +
+         "    return " + old_expression + ";\n" +
+         "}\n" +
+         "var t2 =1;\n");
 
-eval(
-"function Factory(p) {\n"
-+ "return (\n"
-+ function_z_text
-+ ");\n"
-+ "}\n"
-);
+    assertEquals("Cat", ChooseAnimal());
 
-var z6 = Factory(6);
-assertEquals(8, z6());
+    var script = Debug.findScript(ChooseAnimal);
 
-var script = Debug.findScript(Factory);
+    var patch_pos = script.source.indexOf(old_expression);
+    var new_animal_patch = new_expression;
 
-var new_source = script.source.replace(function_z_text, "function Intermediate() {\nreturn (\n" + function_z_text + ")\n;\n}\n");
-print("new source: " + new_source);
+    var change_log = new Array();
+    Debug.LiveEdit.TestApi.ApplySingleChunkPatch(script, patch_pos, old_expression.length, new_expression, change_log);

[Yang, 2012/10/23 16:10:31]

Please keep the 80-char limit.

[Peter Rybin, 2012/11/11 03:28:47]

Done.

+    assertEquals("Capybara", ChooseAnimal());
+}
 
-var change_log = new Array();
-var result = Debug.LiveEdit.SetScriptSource(script, new_source, false, change_log);
-print("Result: " + JSON.stringify(result) + "\n");
-print("Change log: " + JSON.stringify(change_log) + "\n");
+// Check that old literal boilerplate was reset.
+Test("['Cat'][0]", "['Capybara'][0]");
+Test("['Cat'][0]", "{a:'Capybara'}.a");
 
-assertEquals(8, z6());
+// No literals -> 1 literal.
+Test("'Cat'", "['Capybara'][0]");
 
-var z100 = Factory(100)();
+// No literals -> 2 literals.
+Test("'Cat'", "['Capy'][0] + {a:'bara'}.a");
 
-assertEquals(102, z100());
+// 1 literal -> no literals.
+Test("['Cat'][0]", "'Capybara'");
 
+// 2 literals -> no literals.
+Test("['Ca'][0] + {a:'t'}.a", "'Capybara'");
 
+// No literals -> regexp.
+Test("'Cat'", "(/.A.Y.A.A/i).exec('Capybara')[0]");
+
+// Array literal -> regexp.
+Test("['Cat'][0]", "(/.A.Y.A.A/i).exec('Capybara')[0]");
+
+// No literals -> regexp.
+Test("(/.A./i).exec('Cat')[0]", "{c:'Capybara'}.c");

[Yang, 2012/10/23 16:10:31]

the test for regexp -> no literals seems to be missing.

[Peter Rybin, 2012/11/11 03:28:47]

This description was totally misleading anyway. I added 2 more tests and updated
the test routine to create many function instances rather than only one.