Chromium Code Reviews
Help | Chromium Project | Sign in
(337)

Issue 11191039: Issue 2368: LiveEdit crashes when new object/array literal is added (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by Peter Rybin
Modified:
1 year, 5 months ago
Reviewers:
Yang
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Issue 2368: LiveEdit crashes when new object/array literal is added

Committed: https://code.google.com/p/v8/source/detail?r=12952

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : format #

Patch Set 4 : style #

Total comments: 14

Patch Set 5 : follow code review #

Total comments: 2

Patch Set 6 : follow codereview #

Patch Set 7 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -3 lines) Lint Patch
M src/liveedit.cc View 1 2 3 4 5 6 7 chunks +136 lines, -3 lines 0 comments 0 errors Download
A test/mjsunit/debug-liveedit-literals.js View 1 2 3 4 1 chunk +94 lines, -0 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 5
Peter Rybin
1 year, 6 months ago #1
Yang
LGTM if comments are addressed. http://codereview.chromium.org/11191039/diff/6001/src/liveedit.cc File src/liveedit.cc (right): http://codereview.chromium.org/11191039/diff/6001/src/liveedit.cc#newcode1056 src/liveedit.cc:1056: FindJSFunctions(shared_info, result); Running twice ...
1 year, 5 months ago #2
Peter Rybin
http://codereview.chromium.org/11191039/diff/6001/src/liveedit.cc File src/liveedit.cc (right): http://codereview.chromium.org/11191039/diff/6001/src/liveedit.cc#newcode1056 src/liveedit.cc:1056: FindJSFunctions(shared_info, result); On 2012/10/23 16:10:31, Yang wrote: > Running ...
1 year, 5 months ago #3
Peter Rybin
Yang, first I wanted to insist on my approach of 2 heap iterations (see inline ...
1 year, 5 months ago #4
Yang
1 year, 5 months ago #5
LGTM, but some suggestions for naming.

http://codereview.chromium.org/11191039/diff/11001/src/liveedit.cc
File src/liveedit.cc (right):

http://codereview.chromium.org/11191039/diff/11001/src/liveedit.cc#newcode1045
src/liveedit.cc:1045: IterateJSFunctions(*shared_info, &processor);
We usually call this kind of callback *Visitor, as in ClearValuesVisitor. Just
for consistency's sake.

http://codereview.chromium.org/11191039/diff/11001/src/liveedit.cc#newcode1079
src/liveedit.cc:1079: template<typename PROCESSOR>
I think we usually use lowercase for typename. Also, visitor :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6