Issue 11191017: Attempt to reuse an existing Browser instance for application launches in Chrome on Windows 8 Metro…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11191017: Attempt to reuse an existing Browser instance for application launches in Chrome on Windows 8 Metro… (Closed)

Created:
8 years, 2 months ago by ananta

Modified:
8 years, 2 months ago

Reviewers:
Mihai Parparita -not on Chrome

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Attempt to reuse an existing Browser instance for application launches in Chrome on Windows 8 Metro mode. BUG=155388 R=mihaip Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162290

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	chrome/browser/ui/extensions/application_launch.cc	View	1 2 3	2 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mihai Parparita -not on Chrome

LGTM https://codereview.chromium.org/11191017/diff/1/chrome/browser/ui/extensions/application_launch.cc File chrome/browser/ui/extensions/application_launch.cc (right): https://codereview.chromium.org/11191017/diff/1/chrome/browser/ui/extensions/application_launch.cc#newcode117 chrome/browser/ui/extensions/application_launch.cc:117: // In Chrome on Windows 8 in metro ...

8 years, 2 months ago (2012-10-16 23:57:18 UTC) #2

ananta

8 years, 2 months ago (2012-10-17 00:06:06 UTC) #3

https://codereview.chromium.org/11191017/diff/1/chrome/browser/ui/extensions/...
File chrome/browser/ui/extensions/application_launch.cc (right):

https://codereview.chromium.org/11191017/diff/1/chrome/browser/ui/extensions/...
chrome/browser/ui/extensions/application_launch.cc:117: // In Chrome on Windows
8 in metro mode we attempt to reuse an existing
On 2012/10/16 23:57:18, Mihai Parparita wrote:
> This comment just repeats what the code does. Can you instead change it to say
> why we prefer to reuse the window?

Done.

Expand Messages | Collapse Messages