Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1119033003: Sever HTMLImportChild client connection upon disposal. (Closed)

Created:
5 years, 7 months ago by sof
Modified:
5 years, 7 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sever HTMLImportChild client connection upon disposal. Move the notification of the HTMLImportChild going away to its dispose() method (instead of its destructor.) It is unsafe to access the HTMLImportChild after its loader has been cleared, which happens as part of disposal. Hence, clear the client connection at the same time. This is essential for Oilpan, where HTMLImportChild destruction will not happen synchronously with disposal. R=haraken BUG=458222 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194847

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M Source/core/html/imports/HTMLImportChild.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/core/html/imports/HTMLImportChildClient.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/html/imports/LinkImport.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/html/imports/LinkImport.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look. Addresses instability http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fhtmlimports%2Fimport-dynamic-async-notblock-sync.html https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oilpan_ASAN/934/layout-test-results/http/tests/htmlimports/import-dynamic-async-notblock-sync-crash-log.txt
5 years, 7 months ago (2015-05-03 05:49:50 UTC) #2
haraken
LGTM
5 years, 7 months ago (2015-05-03 06:11:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119033003/1
5 years, 7 months ago (2015-05-03 06:46:14 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-03 06:49:05 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194847

Powered by Google App Engine
This is Rietveld 408576698