Add --noopt flag that sets all kind of flags to make unoptimzied code as fast as possible (and not …

runtime/vm/flow_graph_compiler.cc

Index: runtime/vm/flow_graph_compiler.cc
===================================================================
--- runtime/vm/flow_graph_compiler.cc	(revision 45469)
+++ runtime/vm/flow_graph_compiler.cc	(working copy)
@@ -27,6 +27,8 @@
 
 namespace dart {
 
+DEFINE_FLAG(bool, always_megamorphic_calls, false,
+    "Instance call always as megamorphic.");
 DEFINE_FLAG(bool, trace_inlining_intervals, false,
     "Inlining interval diagnostics");
 DEFINE_FLAG(bool, enable_simd_inline, true,
@@ -52,9 +54,24 @@
 DECLARE_FLAG(int, stacktrace_every);
 DECLARE_FLAG(charp, stacktrace_filter);
 DECLARE_FLAG(bool, use_cha);
+DECLARE_FLAG(bool, use_field_guards);
 DECLARE_FLAG(bool, use_osr);
 DECLARE_FLAG(bool, warn_on_javascript_compatibility);
 
+static void NooptModeHandler(bool value) {
+  FLAG_always_megamorphic_calls = value;
+  FLAG_optimization_counter_threshold = -1;

[Florian Schneider, 2015/05/01 20:47:58]

Will this handler called ever with (value == false)?

Maybe do:

if (value) {
  FLAG_always_megamorphic_calls = true;
  FLAG_optimization_counter_threshold = -1;
  FLAG_use_field_guards = false;
}

[srdjan, 2015/05/01 20:55:11]

Done.

+  FLAG_use_field_guards = false;

[Florian Schneider, 2015/05/01 20:47:58]

FLAG_use_osr = false;

to avoid generating OSR checking code?

[srdjan, 2015/05/01 20:55:11]

Done.

+}
+
+
+// --unopt disables optimizer and tunes unoptimized code to run as fast

[Florian Schneider, 2015/05/01 20:47:58]

s/unopt/noopt/

[srdjan, 2015/05/01 20:55:11]

Done.

+// as possible.
+DEFINE_FLAG_HANDLER(NooptModeHandler,
+                    noopt,
+                    "Run fast unoptimized code only.");
+
+
 // Assign locations to incoming arguments, i.e., values pushed above spill slots
 // with PushArgument.  Recursively allocates from outermost to innermost
 // environment.
@@ -983,6 +1000,11 @@
     intptr_t argument_count,
     LocationSummary* locs,
     const ICData& ic_data) {
+  if (FLAG_always_megamorphic_calls) {
+    EmitMegamorphicInstanceCall(ic_data, argument_count,
+                                deopt_id, token_pos, locs);
+    return;
+  }
   ASSERT(!ic_data.IsNull());
   uword label_address = 0;
   StubCode* stub_code = isolate()->stub_code();