src/compiler.cc - Issue 11190050: Heavy cleanup of the external pointer API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 11190050: Heavy cleanup of the external pointer API. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index 86374371e9b81de642cb528ad2b9a89e76c2c7f1..182ee6d9e682e481cf7bf257bef9d238644403e1 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -432,7 +432,9 @@ static Handle<SharedFunctionInfo> MakeFunctionInfo(CompilationInfo* info) {

ASSERT(!isolate->native_context().is_null());

Handle<Script> script = info->script();

- script->set_context_data((*isolate->native_context())->data());

+ // TODO(svenpanne) Obscure place for this, perhaps move to OnBeforeCompile?

+ FixedArray* array = (*isolate->native_context())->embedder_data();

Michael Starzinger 2012/10/25 09:41:53 This can just be "isolate->native_context()->embed

Sven Panne 2012/10/25 14:23:08 Done. Excessive overloading FTW! :-P

+ script->set_context_data(array->get(0));

#ifdef ENABLE_DEBUGGER_SUPPORT

if (info->is_eval()) {