runtime/vm/flow_graph_optimizer.cc - Issue 11190036: Fix optimization of %: replace IC call even if not optimizable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 11190036: Fix optimization of %: replace IC call even if not optimizable. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

===================================================================

--- runtime/vm/flow_graph_optimizer.cc (revision 13759)

+++ runtime/vm/flow_graph_optimizer.cc (working copy)

@@ -653,6 +653,9 @@

new BinarySmiOpInstr(Token::kBIT_AND, call, left, new Value(c));

call->ReplaceWith(bin_op, current_iterator());

RemovePushArguments(call);

+ } else {

+ // Did not replace.

+ return false;

}

} else {

ASSERT(operands_type == kSmiCid);

« no previous file with comments | « no previous file | no next file » | no next file with comments »