Issue 11190019: Fix 'for' construct which caused crash when VLOG is on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11190019: Fix 'for' construct which caused crash when VLOG is on. (Closed)

Created:
8 years, 2 months ago by kochi

Modified:
8 years, 2 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix 'for' construct which caused crash when VLOG is on. BUG=none TEST=run chrome with --vmodule=drive_webapprs_registry=1 and login with an account with some drive apps installed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162341

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	chrome/browser/chromeos/drive/drive_webapps_registry.cc	View		1 chunk	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kochi

Hi Ryo, This is low-priority review request, but should be obvious. When VLOG is enabled ...

8 years, 2 months ago (2012-10-17 09:42:24 UTC) #1

hashimoto

lgtm Thank you for fixing this. Got curious why the original code was committed without ...

8 years, 2 months ago (2012-10-17 09:52:55 UTC) #2

Greg Spencer (Chromium)

8 years, 2 months ago (2012-10-17 16:34:11 UTC) #3

On 2012/10/17 09:52:55, hashimoto wrote:
> lgtm
> 
> Thank you for fixing this.
> Got curious why the original code was committed without noticing this problem…

Yes, thanks for fixing it.  I did run this, but maybe not after I changed this
part of the code.  Sorry about that.

Expand Messages | Collapse Messages