Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 11190011: Add an API for enumerating persistent handles (Closed)

Created:
8 years, 2 months ago by abarth-chromium
Modified:
8 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add an API for enumerating persistent handles This API lets the embedder enumerate handles that have class ids. WebKit will use this feature during garbage collection to compute object groups for DOM nodes. Previously, we kept a list of DOM nodes on the WebKit side, but that list is redundant with the global handles list in V8. Committed: https://code.google.com/p/v8/source/detail?r=12750

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 4

Patch Set 8 : #

Patch Set 9 : Addressed reviewer feedback and added tests #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -8 lines) Patch
M include/v8.h View 1 2 3 4 5 6 7 8 9 chunks +44 lines, -8 lines 0 comments Download
M src/api.cc View 1 2 3 4 5 6 7 8 3 chunks +37 lines, -0 lines 0 comments Download
M src/global-handles.h View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -0 lines 0 comments Download
M src/global-handles.cc View 1 2 3 4 5 6 7 8 2 chunks +8 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 5 6 7 8 9 2 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
abarth-chromium
This patch is a work-in-progress. I'm working on the WebKit side of the change now ...
8 years, 2 months ago (2012-10-16 23:12:58 UTC) #1
abarth-chromium
Ok, this is ready for review. I've also added some accessors that are useful for ...
8 years, 2 months ago (2012-10-17 05:42:05 UTC) #2
abarth-chromium
If you're interested, you can see the WebKit side of this work in https://github.com/abarth/webkit/compare/master...newgc
8 years, 2 months ago (2012-10-17 06:09:31 UTC) #3
Michael Starzinger
This is looking good. Just some minor nits. Unfortunately I will be OOO until next ...
8 years, 2 months ago (2012-10-17 08:47:47 UTC) #4
abarth-chromium
I've uploaded a new version of the patch that addresses all reviewer feedback and adds ...
8 years, 2 months ago (2012-10-17 18:45:45 UTC) #5
Sven Panne
LGTM, landing... P.S.: Please use bleeding_edge as the base URL for patches.
8 years, 2 months ago (2012-10-18 06:40:03 UTC) #6
abarth-chromium
8 years, 2 months ago (2012-10-18 16:32:30 UTC) #7
On 2012/10/18 06:40:03, Sven Panne wrote:
> LGTM, landing...

Thanks!

> P.S.: Please use bleeding_edge as the base URL for patches.

Will do.

Powered by Google App Engine
This is Rietveld 408576698