Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 1118993002: Oilpan: IDL union objects should be put in HeapVector (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/templates/union.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_types.py
diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py
index 277ea8bd1cf040b0054fbbc6c42809e81113cfaf..c02da3f5a397ff05b220c0ca3d2bd5449012cdeb 100644
--- a/Source/bindings/scripts/v8_types.py
+++ b/Source/bindings/scripts/v8_types.py
@@ -310,7 +310,7 @@ IdlType.set_will_be_garbage_collected_types = classmethod(
def gc_type(idl_type):
- if idl_type.is_garbage_collected or idl_type.is_dictionary:
+ if idl_type.is_garbage_collected or idl_type.is_dictionary or idl_type.is_union_type:
return 'GarbageCollectedObject'
if idl_type.is_will_be_garbage_collected:
return 'WillBeGarbageCollectedObject'
@@ -322,7 +322,8 @@ IdlTypeBase.gc_type = property(gc_type)
def is_traceable(idl_type):
return (idl_type.is_garbage_collected
or idl_type.is_will_be_garbage_collected
- or idl_type.is_dictionary)
+ or idl_type.is_dictionary
+ or idl_type.is_union_type)
IdlTypeBase.is_traceable = property(is_traceable)
IdlUnionType.is_traceable = property(
@@ -593,7 +594,7 @@ def v8_value_to_cpp_value_array_or_sequence(native_array_element_type, v8_value,
else:
ref_ptr_type = None
this_cpp_type = native_array_element_type.cpp_type
- if native_array_element_type.is_dictionary:
+ if native_array_element_type.is_dictionary or native_array_element_type.is_union_type:
vector_type = 'HeapVector'
else:
vector_type = 'Vector'
« no previous file with comments | « no previous file | Source/bindings/templates/union.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698