Issue 1118983003: Save 8 bytes in each CFX_ByteString/WideString (on "LP64" platforms).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1118983003: Save 8 bytes in each CFX_ByteString/WideString (on "LP64" platforms). (Closed)

Created:
5 years, 7 months ago by Tom Sepez

Modified:
5 years, 7 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Save 8 bytes in each CFX_ByteString/WideString (on "LP64" platforms). (Also makes the calculation robust in face of changes to the header). BUG=pdfium:149 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/72fb2e8d680c697be06c4325ddc827c3989bf3c1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	core/src/fxcrt/fx_basic_bstring.cpp	View		2 chunks	+5 lines, -1 line	0 comments	Download
	M	core/src/fxcrt/fx_basic_wstring.cpp	View		2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years, 7 months ago (2015-05-01 21:49:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
72fb2e8d680c697be06c4325ddc827c3989bf3c1 (presubmit successful).