Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: pkg/analyzer/lib/src/context/context.dart

Issue 1118963003: Fix for computing IS_CLIENT. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/task/dart.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/context/context.dart
diff --git a/pkg/analyzer/lib/src/context/context.dart b/pkg/analyzer/lib/src/context/context.dart
index 29204a133c1559d45824c9145cdceaa83f5e7b71..b8158c2410541dbf17867ca6aef40184a778694d 100644
--- a/pkg/analyzer/lib/src/context/context.dart
+++ b/pkg/analyzer/lib/src/context/context.dart
@@ -259,8 +259,6 @@ class AnalysisContextImpl implements InternalAnalysisContext {
@override
List<Source> get launchableClientLibrarySources {
- // TODO(brianwilkerson) This needs to filter out libraries that do not
- // reference dart:html, either directly or indirectly.
List<Source> sources = new List<Source>();
MapIterator<AnalysisTarget, cache.CacheEntry> iterator = _cache.iterator();
while (iterator.moveNext()) {
@@ -268,11 +266,9 @@ class AnalysisContextImpl implements InternalAnalysisContext {
cache.CacheEntry entry = iterator.value;
if (target is Source &&
entry.getValue(SOURCE_KIND) == SourceKind.LIBRARY &&
- !target.isInSystemLibrary) {
-// DartEntry dartEntry = (DartEntry) sourceEntry;
-// if (dartEntry.getValue(DartEntry.IS_LAUNCHABLE) && !dartEntry.getValue(DartEntry.IS_CLIENT)) {
+ !target.isInSystemLibrary &&
+ isClientLibrary(target)) {
sources.add(target);
-// }
}
}
return sources;
@@ -568,16 +564,16 @@ class AnalysisContextImpl implements InternalAnalysisContext {
HtmlElement computeHtmlElement(Source source) => null;
@override
- List<Source> computeImportedLibraries(Source source) => _computeResult(
- source, IMPORTED_LIBRARIES);
+ List<Source> computeImportedLibraries(Source source) =>
+ _computeResult(source, IMPORTED_LIBRARIES);
@override
SourceKind computeKindOf(Source source) =>
_computeResult(source, SOURCE_KIND);
@override
- LibraryElement computeLibraryElement(Source source) =>
- _computeResult(source, LIBRARY_ELEMENT); //_computeResult(source, HtmlEntry.ELEMENT);
+ LibraryElement computeLibraryElement(Source source) => _computeResult(
+ source, LIBRARY_ELEMENT); //_computeResult(source, HtmlEntry.ELEMENT);
@override
LineInfo computeLineInfo(Source source) => _computeResult(source, LINE_INFO);
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/task/dart.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698