Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Unified Diff: Source/core/inspector/PageDebuggerAgent.cpp

Issue 1118963002: Revert of DevTools: remove dependency of most agents on InspectorPageAgent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/PageDebuggerAgent.h ('k') | Source/core/inspector/PageRuntimeAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/PageDebuggerAgent.cpp
diff --git a/Source/core/inspector/PageDebuggerAgent.cpp b/Source/core/inspector/PageDebuggerAgent.cpp
index 197918beab71383dec356e7af01bfc1fe9c85b26..f0adbadeb2bb12da4df928bea1dd823eb514652c 100644
--- a/Source/core/inspector/PageDebuggerAgent.cpp
+++ b/Source/core/inspector/PageDebuggerAgent.cpp
@@ -38,21 +38,22 @@
#include "core/frame/LocalFrame.h"
#include "core/inspector/InjectedScript.h"
#include "core/inspector/InspectorOverlay.h"
+#include "core/inspector/InspectorPageAgent.h"
#include "core/inspector/InstrumentingAgents.h"
#include "core/loader/DocumentLoader.h"
#include "core/page/Page.h"
namespace blink {
-PassOwnPtrWillBeRawPtr<PageDebuggerAgent> PageDebuggerAgent::create(LocalFrame* inspectedFrame, PageScriptDebugServer* pageScriptDebugServer, InjectedScriptManager* injectedScriptManager, InspectorOverlay* overlay, int debuggerId)
+PassOwnPtrWillBeRawPtr<PageDebuggerAgent> PageDebuggerAgent::create(PageScriptDebugServer* pageScriptDebugServer, InspectorPageAgent* pageAgent, InjectedScriptManager* injectedScriptManager, InspectorOverlay* overlay, int debuggerId)
{
- return adoptPtrWillBeNoop(new PageDebuggerAgent(inspectedFrame, pageScriptDebugServer, injectedScriptManager, overlay, debuggerId));
+ return adoptPtrWillBeNoop(new PageDebuggerAgent(pageScriptDebugServer, pageAgent, injectedScriptManager, overlay, debuggerId));
}
-PageDebuggerAgent::PageDebuggerAgent(LocalFrame* inspectedFrame, PageScriptDebugServer* pageScriptDebugServer, InjectedScriptManager* injectedScriptManager, InspectorOverlay* overlay, int debuggerId)
+PageDebuggerAgent::PageDebuggerAgent(PageScriptDebugServer* pageScriptDebugServer, InspectorPageAgent* pageAgent, InjectedScriptManager* injectedScriptManager, InspectorOverlay* overlay, int debuggerId)
: InspectorDebuggerAgent(injectedScriptManager)
- , m_inspectedFrame(inspectedFrame)
, m_pageScriptDebugServer(pageScriptDebugServer)
+ , m_pageAgent(pageAgent)
, m_overlay(overlay)
, m_debuggerId(debuggerId)
{
@@ -65,8 +66,8 @@
DEFINE_TRACE(PageDebuggerAgent)
{
- visitor->trace(m_inspectedFrame);
visitor->trace(m_pageScriptDebugServer);
+ visitor->trace(m_pageAgent);
visitor->trace(m_overlay);
InspectorDebuggerAgent::trace(visitor);
}
@@ -85,12 +86,12 @@
void PageDebuggerAgent::startListeningScriptDebugServer()
{
- scriptDebugServer().addListener(this, m_inspectedFrame, m_debuggerId);
+ scriptDebugServer().addListener(this, m_pageAgent->inspectedFrame(), m_debuggerId);
}
void PageDebuggerAgent::stopListeningScriptDebugServer()
{
- scriptDebugServer().removeListener(this, m_inspectedFrame);
+ scriptDebugServer().removeListener(this, m_pageAgent->inspectedFrame());
}
PageScriptDebugServer& PageDebuggerAgent::scriptDebugServer()
@@ -123,7 +124,7 @@
InjectedScript PageDebuggerAgent::injectedScriptForEval(ErrorString* errorString, const int* executionContextId)
{
if (!executionContextId) {
- ScriptState* scriptState = ScriptState::forMainWorld(m_inspectedFrame);
+ ScriptState* scriptState = ScriptState::forMainWorld(m_pageAgent->inspectedFrame());
InjectedScript result = injectedScriptManager()->injectedScriptFor(scriptState);
if (result.isEmpty())
*errorString = "Internal error: main world execution context not found.";
@@ -137,7 +138,7 @@
void PageDebuggerAgent::didStartProvisionalLoad(LocalFrame* frame)
{
- if (frame == m_inspectedFrame) {
+ if (frame == m_pageAgent->inspectedFrame()) {
ErrorString error;
resume(&error);
}
@@ -146,7 +147,7 @@
void PageDebuggerAgent::didClearDocumentOfWindowObject(LocalFrame* frame)
{
// FIXME: what about nested objects?
- if (frame != m_inspectedFrame)
+ if (frame != m_pageAgent->inspectedFrame())
return;
reset();
}
« no previous file with comments | « Source/core/inspector/PageDebuggerAgent.h ('k') | Source/core/inspector/PageRuntimeAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698