Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: Source/web/WebDevToolsAgentImpl.cpp

Issue 1118963002: Revert of DevTools: remove dependency of most agents on InspectorPageAgent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/inspector/PageRuntimeAgent.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 288 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 , m_agents(m_instrumentingAgents.get(), m_state.get()) 299 , m_agents(m_instrumentingAgents.get(), m_state.get())
300 , m_deferredAgentsInitialized(false) 300 , m_deferredAgentsInitialized(false)
301 { 301 {
302 ASSERT(isMainThread()); 302 ASSERT(isMainThread());
303 ASSERT(m_webLocalFrameImpl->frame()); 303 ASSERT(m_webLocalFrameImpl->frame());
304 304
305 long processId = WTF::getCurrentProcessID(); 305 long processId = WTF::getCurrentProcessID();
306 ASSERT(processId > 0); 306 ASSERT(processId > 0);
307 IdentifiersFactory::setProcessId(processId); 307 IdentifiersFactory::setProcessId(processId);
308 InjectedScriptManager* injectedScriptManager = m_injectedScriptManager.get() ; 308 InjectedScriptManager* injectedScriptManager = m_injectedScriptManager.get() ;
309 LocalFrame* inspectedFrame = m_webLocalFrameImpl->frame();
310 309
311 OwnPtrWillBeRawPtr<InspectorInspectorAgent> inspectorAgentPtr(InspectorInspe ctorAgent::create(injectedScriptManager)); 310 OwnPtrWillBeRawPtr<InspectorInspectorAgent> inspectorAgentPtr(InspectorInspe ctorAgent::create(injectedScriptManager));
312 m_inspectorAgent = inspectorAgentPtr.get(); 311 m_inspectorAgent = inspectorAgentPtr.get();
313 m_agents.append(inspectorAgentPtr.release()); 312 m_agents.append(inspectorAgentPtr.release());
314 313
315 OwnPtrWillBeRawPtr<InspectorPageAgent> pageAgentPtr(InspectorPageAgent::crea te(inspectedFrame, m_overlay)); 314 OwnPtrWillBeRawPtr<InspectorPageAgent> pageAgentPtr(InspectorPageAgent::crea te(m_webLocalFrameImpl->frame(), m_overlay));
316 m_pageAgent = pageAgentPtr.get(); 315 m_pageAgent = pageAgentPtr.get();
317 m_agents.append(pageAgentPtr.release()); 316 m_agents.append(pageAgentPtr.release());
318 317
319 OwnPtrWillBeRawPtr<InspectorDOMAgent> domAgentPtr(InspectorDOMAgent::create( inspectedFrame, injectedScriptManager, m_overlay)); 318 OwnPtrWillBeRawPtr<InspectorDOMAgent> domAgentPtr(InspectorDOMAgent::create( m_pageAgent, injectedScriptManager, m_overlay));
320 m_domAgent = domAgentPtr.get(); 319 m_domAgent = domAgentPtr.get();
321 m_agents.append(domAgentPtr.release()); 320 m_agents.append(domAgentPtr.release());
322 321
323 OwnPtrWillBeRawPtr<InspectorLayerTreeAgent> layerTreeAgentPtr(InspectorLayer TreeAgent::create(inspectedFrame)); 322 OwnPtrWillBeRawPtr<InspectorLayerTreeAgent> layerTreeAgentPtr(InspectorLayer TreeAgent::create(m_pageAgent));
324 m_layerTreeAgent = layerTreeAgentPtr.get(); 323 m_layerTreeAgent = layerTreeAgentPtr.get();
325 m_agents.append(layerTreeAgentPtr.release()); 324 m_agents.append(layerTreeAgentPtr.release());
326 325
327 m_agents.append(InspectorTimelineAgent::create()); 326 m_agents.append(InspectorTimelineAgent::create());
328 327
329 ClientMessageLoopAdapter::ensurePageScriptDebugServerCreated(m_client); 328 ClientMessageLoopAdapter::ensurePageScriptDebugServerCreated(m_client);
330 PageScriptDebugServer* scriptDebugServer = PageScriptDebugServer::instance() ; 329 PageScriptDebugServer* scriptDebugServer = PageScriptDebugServer::instance() ;
331 330
332 OwnPtrWillBeRawPtr<PageRuntimeAgent> pageRuntimeAgentPtr(PageRuntimeAgent::c reate(inspectedFrame, injectedScriptManager, this, scriptDebugServer)); 331 OwnPtrWillBeRawPtr<PageRuntimeAgent> pageRuntimeAgentPtr(PageRuntimeAgent::c reate(injectedScriptManager, this, scriptDebugServer, m_pageAgent));
333 m_pageRuntimeAgent = pageRuntimeAgentPtr.get(); 332 m_pageRuntimeAgent = pageRuntimeAgentPtr.get();
334 m_agents.append(pageRuntimeAgentPtr.release()); 333 m_agents.append(pageRuntimeAgentPtr.release());
335 334
336 OwnPtrWillBeRawPtr<PageConsoleAgent> pageConsoleAgentPtr = PageConsoleAgent: :create(inspectedFrame, injectedScriptManager, m_domAgent); 335 OwnPtrWillBeRawPtr<PageConsoleAgent> pageConsoleAgentPtr = PageConsoleAgent: :create(injectedScriptManager, m_domAgent, m_pageAgent);
337 m_pageConsoleAgent = pageConsoleAgentPtr.get(); 336 m_pageConsoleAgent = pageConsoleAgentPtr.get();
338 337
339 OwnPtrWillBeRawPtr<InspectorWorkerAgent> workerAgentPtr = InspectorWorkerAge nt::create(pageConsoleAgentPtr.get()); 338 OwnPtrWillBeRawPtr<InspectorWorkerAgent> workerAgentPtr = InspectorWorkerAge nt::create(pageConsoleAgentPtr.get());
340 339
341 OwnPtrWillBeRawPtr<InspectorTracingAgent> tracingAgentPtr = InspectorTracing Agent::create(inspectedFrame, this, workerAgentPtr.get()); 340 OwnPtrWillBeRawPtr<InspectorTracingAgent> tracingAgentPtr = InspectorTracing Agent::create(this, workerAgentPtr.get(), m_pageAgent);
342 m_tracingAgent = tracingAgentPtr.get(); 341 m_tracingAgent = tracingAgentPtr.get();
343 m_agents.append(tracingAgentPtr.release()); 342 m_agents.append(tracingAgentPtr.release());
344 343
345 m_agents.append(workerAgentPtr.release()); 344 m_agents.append(workerAgentPtr.release());
346 m_agents.append(pageConsoleAgentPtr.release()); 345 m_agents.append(pageConsoleAgentPtr.release());
347 } 346 }
348 347
349 WebDevToolsAgentImpl::~WebDevToolsAgentImpl() 348 WebDevToolsAgentImpl::~WebDevToolsAgentImpl()
350 { 349 {
351 ASSERT(m_hasBeenDisposed); 350 ASSERT(m_hasBeenDisposed);
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 visitor->trace(m_tracingAgent); 390 visitor->trace(m_tracingAgent);
392 visitor->trace(m_pageRuntimeAgent); 391 visitor->trace(m_pageRuntimeAgent);
393 visitor->trace(m_pageConsoleAgent); 392 visitor->trace(m_pageConsoleAgent);
394 visitor->trace(m_inspectorBackendDispatcher); 393 visitor->trace(m_inspectorBackendDispatcher);
395 visitor->trace(m_agents); 394 visitor->trace(m_agents);
396 } 395 }
397 396
398 void WebDevToolsAgentImpl::willBeDestroyed() 397 void WebDevToolsAgentImpl::willBeDestroyed()
399 { 398 {
400 #if ENABLE(ASSERT) 399 #if ENABLE(ASSERT)
401 LocalFrame* frame = m_webLocalFrameImpl->frame(); 400 Frame* frame = m_webLocalFrameImpl->frame();
402 ASSERT(frame); 401 ASSERT(frame);
403 ASSERT(frame->view()); 402 ASSERT(m_pageAgent->inspectedFrame()->view());
404 #endif 403 #endif
405 404
406 detach(); 405 detach();
407 m_injectedScriptManager->disconnect(); 406 m_injectedScriptManager->disconnect();
408 m_agents.discardAgents(); 407 m_agents.discardAgents();
409 m_instrumentingAgents->reset(); 408 m_instrumentingAgents->reset();
410 } 409 }
411 410
412 void WebDevToolsAgentImpl::initializeDeferredAgents() 411 void WebDevToolsAgentImpl::initializeDeferredAgents()
413 { 412 {
414 if (m_deferredAgentsInitialized) 413 if (m_deferredAgentsInitialized)
415 return; 414 return;
416 m_deferredAgentsInitialized = true; 415 m_deferredAgentsInitialized = true;
417 416
418 InjectedScriptManager* injectedScriptManager = m_injectedScriptManager.get() ; 417 InjectedScriptManager* injectedScriptManager = m_injectedScriptManager.get() ;
419 LocalFrame* inspectedFrame = m_webLocalFrameImpl->frame();
420 418
421 OwnPtrWillBeRawPtr<InspectorResourceAgent> resourceAgentPtr(InspectorResourc eAgent::create(inspectedFrame)); 419 OwnPtrWillBeRawPtr<InspectorResourceAgent> resourceAgentPtr(InspectorResourc eAgent::create(m_pageAgent));
422 m_resourceAgent = resourceAgentPtr.get(); 420 m_resourceAgent = resourceAgentPtr.get();
423 m_agents.append(resourceAgentPtr.release()); 421 m_agents.append(resourceAgentPtr.release());
424 422
425 OwnPtrWillBeRawPtr<InspectorCSSAgent> cssAgentPtr(InspectorCSSAgent::create( inspectedFrame, m_domAgent, m_pageAgent, m_resourceAgent)); 423 OwnPtrWillBeRawPtr<InspectorCSSAgent> cssAgentPtr(InspectorCSSAgent::create( m_domAgent, m_pageAgent, m_resourceAgent));
426 m_cssAgent = cssAgentPtr.get(); 424 m_cssAgent = cssAgentPtr.get();
427 m_agents.append(cssAgentPtr.release()); 425 m_agents.append(cssAgentPtr.release());
428 426
429 m_agents.append(InspectorAnimationAgent::create(inspectedFrame, m_domAgent)) ; 427 m_agents.append(InspectorAnimationAgent::create(m_pageAgent, m_domAgent));
430 428
431 m_agents.append(InspectorMemoryAgent::create()); 429 m_agents.append(InspectorMemoryAgent::create());
432 430
433 m_agents.append(InspectorApplicationCacheAgent::create(inspectedFrame)); 431 m_agents.append(InspectorApplicationCacheAgent::create(m_pageAgent));
434 432
435 OwnPtrWillBeRawPtr<InspectorDebuggerAgent> debuggerAgentPtr(PageDebuggerAgen t::create(inspectedFrame, PageScriptDebugServer::instance(), injectedScriptManag er, m_overlay, m_pageRuntimeAgent->debuggerId())); 433 OwnPtrWillBeRawPtr<InspectorDebuggerAgent> debuggerAgentPtr(PageDebuggerAgen t::create(PageScriptDebugServer::instance(), m_pageAgent, injectedScriptManager, m_overlay, m_pageRuntimeAgent->debuggerId()));
436 InspectorDebuggerAgent* debuggerAgent = debuggerAgentPtr.get(); 434 InspectorDebuggerAgent* debuggerAgent = debuggerAgentPtr.get();
437 m_agents.append(debuggerAgentPtr.release()); 435 m_agents.append(debuggerAgentPtr.release());
438 m_asyncCallTracker = adoptPtrWillBeNoop(new AsyncCallTracker(debuggerAgent, m_instrumentingAgents.get())); 436 m_asyncCallTracker = adoptPtrWillBeNoop(new AsyncCallTracker(debuggerAgent, m_instrumentingAgents.get()));
439 437
440 m_agents.append(InspectorDOMDebuggerAgent::create(m_domAgent, debuggerAgent) ); 438 m_agents.append(InspectorDOMDebuggerAgent::create(m_domAgent, debuggerAgent) );
441 439
442 m_agents.append(InspectorInputAgent::create(inspectedFrame)); 440 m_agents.append(InspectorInputAgent::create(m_pageAgent));
443 441
444 m_agents.append(InspectorProfilerAgent::create(injectedScriptManager, m_over lay)); 442 m_agents.append(InspectorProfilerAgent::create(injectedScriptManager, m_over lay));
445 443
446 m_agents.append(InspectorHeapProfilerAgent::create(injectedScriptManager)); 444 m_agents.append(InspectorHeapProfilerAgent::create(injectedScriptManager));
447 445
448 m_pageAgent->setDeferredAgents(debuggerAgent, m_cssAgent); 446 m_pageAgent->setDeferredAgents(debuggerAgent, m_cssAgent);
449 447
450 PageScriptDebugServer* scriptDebugServer = PageScriptDebugServer::instance() ; 448 PageScriptDebugServer* scriptDebugServer = PageScriptDebugServer::instance() ;
451 m_injectedScriptManager->injectedScriptHost()->init( 449 m_injectedScriptManager->injectedScriptHost()->init(
452 m_pageConsoleAgent.get(), 450 m_pageConsoleAgent.get(),
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
722 if (!InspectorBackendDispatcher::getCommandName(message, &commandName)) 720 if (!InspectorBackendDispatcher::getCommandName(message, &commandName))
723 return false; 721 return false;
724 return commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_pauseCmd) 722 return commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_pauseCmd)
725 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointCmd) 723 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointCmd)
726 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointByUrlCmd) 724 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointByUrlCmd)
727 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_removeBreakpointCmd) 725 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_removeBreakpointCmd)
728 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointsActiveCmd); 726 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointsActiveCmd);
729 } 727 }
730 728
731 } // namespace blink 729 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/inspector/PageRuntimeAgent.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698