Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: Source/core/inspector/InspectorTracingAgent.cpp

Issue 1118963002: Revert of DevTools: remove dependency of most agents on InspectorPageAgent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/inspector/InspectorTracingAgent.h ('k') | Source/core/inspector/PageConsoleAgent.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // 1 //
2 // Copyright 2014 The Chromium Authors. All rights reserved. 2 // Copyright 2014 The Chromium Authors. All rights reserved.
3 // Use of this source code is governed by a BSD-style license that can be 3 // Use of this source code is governed by a BSD-style license that can be
4 // found in the LICENSE file. 4 // found in the LICENSE file.
5 // 5 //
6 6
7 #include "config.h" 7 #include "config.h"
8 8
9 #include "core/inspector/InspectorTracingAgent.h" 9 #include "core/inspector/InspectorTracingAgent.h"
10 10
11 #include "core/inspector/IdentifiersFactory.h" 11 #include "core/inspector/IdentifiersFactory.h"
12 #include "core/inspector/InspectorPageAgent.h"
12 #include "core/inspector/InspectorState.h" 13 #include "core/inspector/InspectorState.h"
13 #include "core/inspector/InspectorTraceEvents.h" 14 #include "core/inspector/InspectorTraceEvents.h"
14 #include "core/inspector/InspectorWorkerAgent.h" 15 #include "core/inspector/InspectorWorkerAgent.h"
15 #include "platform/TraceEvent.h" 16 #include "platform/TraceEvent.h"
16 17
17 namespace blink { 18 namespace blink {
18 19
19 namespace TracingAgentState { 20 namespace TracingAgentState {
20 const char sessionId[] = "sessionId"; 21 const char sessionId[] = "sessionId";
21 } 22 }
22 23
23 namespace { 24 namespace {
24 const char devtoolsMetadataEventCategory[] = TRACE_DISABLED_BY_DEFAULT("devtools .timeline"); 25 const char devtoolsMetadataEventCategory[] = TRACE_DISABLED_BY_DEFAULT("devtools .timeline");
25 } 26 }
26 27
27 InspectorTracingAgent::InspectorTracingAgent(LocalFrame* inspectedFrame, Client* client, InspectorWorkerAgent* workerAgent) 28 InspectorTracingAgent::InspectorTracingAgent(Client* client, InspectorWorkerAgen t* workerAgent, InspectorPageAgent* pageAgent)
28 : InspectorBaseAgent<InspectorTracingAgent, InspectorFrontend::Tracing>("Tra cing") 29 : InspectorBaseAgent<InspectorTracingAgent, InspectorFrontend::Tracing>("Tra cing")
29 , m_inspectedFrame(inspectedFrame)
30 , m_layerTreeId(0) 30 , m_layerTreeId(0)
31 , m_client(client) 31 , m_client(client)
32 , m_workerAgent(workerAgent) 32 , m_workerAgent(workerAgent)
33 , m_pageAgent(pageAgent)
33 { 34 {
34 } 35 }
35 36
36 DEFINE_TRACE(InspectorTracingAgent) 37 DEFINE_TRACE(InspectorTracingAgent)
37 { 38 {
38 visitor->trace(m_inspectedFrame);
39 visitor->trace(m_workerAgent); 39 visitor->trace(m_workerAgent);
40 visitor->trace(m_pageAgent);
40 InspectorBaseAgent::trace(visitor); 41 InspectorBaseAgent::trace(visitor);
41 } 42 }
42 43
43 void InspectorTracingAgent::restore() 44 void InspectorTracingAgent::restore()
44 { 45 {
45 emitMetadataEvents(); 46 emitMetadataEvents();
46 } 47 }
47 48
48 void InspectorTracingAgent::start(ErrorString*, const String* categoryFilter, co nst String*, const double*, PassRefPtrWillBeRawPtr<StartCallback> callback) 49 void InspectorTracingAgent::start(ErrorString*, const String* categoryFilter, co nst String*, const double*, PassRefPtrWillBeRawPtr<StartCallback> callback)
49 { 50 {
(...skipping 11 matching lines...) Expand all
61 callback->sendSuccess(); 62 callback->sendSuccess();
62 } 63 }
63 64
64 String InspectorTracingAgent::sessionId() 65 String InspectorTracingAgent::sessionId()
65 { 66 {
66 return m_state->getString(TracingAgentState::sessionId); 67 return m_state->getString(TracingAgentState::sessionId);
67 } 68 }
68 69
69 void InspectorTracingAgent::emitMetadataEvents() 70 void InspectorTracingAgent::emitMetadataEvents()
70 { 71 {
71 TRACE_EVENT_INSTANT1(devtoolsMetadataEventCategory, "TracingStartedInPage", TRACE_EVENT_SCOPE_THREAD, "data", InspectorTracingStartedInFrame::data(sessionId (), m_inspectedFrame)); 72 TRACE_EVENT_INSTANT1(devtoolsMetadataEventCategory, "TracingStartedInPage", TRACE_EVENT_SCOPE_THREAD, "data", InspectorTracingStartedInFrame::data(sessionId (), m_pageAgent->inspectedFrame()));
72 if (m_layerTreeId) 73 if (m_layerTreeId)
73 setLayerTreeId(m_layerTreeId); 74 setLayerTreeId(m_layerTreeId);
74 m_workerAgent->setTracingSessionId(sessionId()); 75 m_workerAgent->setTracingSessionId(sessionId());
75 } 76 }
76 77
77 void InspectorTracingAgent::setLayerTreeId(int layerTreeId) 78 void InspectorTracingAgent::setLayerTreeId(int layerTreeId)
78 { 79 {
79 m_layerTreeId = layerTreeId; 80 m_layerTreeId = layerTreeId;
80 TRACE_EVENT_INSTANT1(devtoolsMetadataEventCategory, "SetLayerTreeId", TRACE_ EVENT_SCOPE_THREAD, "data", InspectorSetLayerTreeId::data(sessionId(), m_layerTr eeId)); 81 TRACE_EVENT_INSTANT1(devtoolsMetadataEventCategory, "SetLayerTreeId", TRACE_ EVENT_SCOPE_THREAD, "data", InspectorSetLayerTreeId::data(sessionId(), m_layerTr eeId));
81 } 82 }
82 83
83 void InspectorTracingAgent::disable(ErrorString*) 84 void InspectorTracingAgent::disable(ErrorString*)
84 { 85 {
85 resetSessionId(); 86 resetSessionId();
86 } 87 }
87 88
88 void InspectorTracingAgent::resetSessionId() 89 void InspectorTracingAgent::resetSessionId()
89 { 90 {
90 m_state->remove(TracingAgentState::sessionId); 91 m_state->remove(TracingAgentState::sessionId);
91 m_workerAgent->setTracingSessionId(sessionId()); 92 m_workerAgent->setTracingSessionId(sessionId());
92 } 93 }
93 94
94 } 95 }
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorTracingAgent.h ('k') | Source/core/inspector/PageConsoleAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698