Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 1118963002: Revert of DevTools: remove dependency of most agents on InspectorPageAgent (Closed)

Created:
5 years ago by caseq
Modified:
5 years ago
Reviewers:
dgozman, pfeldman, yurys
CC:
blink-reviews, Eric Willigers, caseq+blink_chromium.org, shans, loislo+blink_chromium.org, dstockwell, blink-reviews-animation_chromium.org, darktears, yurys+blink_chromium.org, lushnikov+blink_chromium.org, Mike Lawther (Google), pfeldman+blink_chromium.org, Timothy Loh, Steve Block, apavlov+blink_chromium.org, devtools-reviews_chromium.org, rjwright, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of DevTools: remove dependency of most agents on InspectorPageAgent (patchset #6 id:100001 of https://codereview.chromium.org/1092123004/) Reason for revert: Reverting as a possible cause of issue 482468 BUG=482468 Original issue's description: > DevTools: remove dependency of most agents on InspectorPageAgent > > - let agents keep inspected frame directly rather than fetch it > from InspectorPageAgent::inspectedFrame(); > - get frames from InspectorIdentifiers<LocalFrame>, but check it > belongs to inspected page; > > BUG=480341 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194592 TBR=dgozman@chromium.org,pfeldman@chromium.org,yurys@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480341 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194801

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -246 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorAnimationAgent.h View 3 chunks +7 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorAnimationAgent.cpp View 7 chunks +8 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorApplicationCacheAgent.h View 3 chunks +5 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorApplicationCacheAgent.cpp View 6 chunks +11 lines, -16 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 5 chunks +3 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.h View 4 chunks +5 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 10 chunks +22 lines, -26 lines 0 comments Download
M Source/core/inspector/InspectorInputAgent.h View 2 chunks +7 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorInputAgent.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.h View 4 chunks +5 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.cpp View 5 chunks +11 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.h View 2 chunks +6 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 10 chunks +46 lines, -11 lines 0 comments Download
D Source/core/inspector/InspectorResolver.h View 1 chunk +0 lines, -26 lines 0 comments Download
D Source/core/inspector/InspectorResolver.cpp View 1 chunk +0 lines, -39 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.h View 4 chunks +5 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 7 chunks +7 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorTracingAgent.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorTracingAgent.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M Source/core/inspector/PageConsoleAgent.h View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/inspector/PageConsoleAgent.cpp View 4 chunks +6 lines, -5 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.h View 3 chunks +5 lines, -4 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.cpp View 6 chunks +11 lines, -10 lines 0 comments Download
M Source/core/inspector/PageRuntimeAgent.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/PageRuntimeAgent.cpp View 5 chunks +6 lines, -5 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 4 chunks +16 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
caseq
Created Revert of DevTools: remove dependency of most agents on InspectorPageAgent
5 years ago (2015-05-01 10:43:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118963002/1
5 years ago (2015-05-01 10:43:11 UTC) #2
commit-bot: I haz the power
5 years ago (2015-05-01 10:43:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194801

Powered by Google App Engine
This is Rietveld 408576698