Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 1118953002: Use of base::StringPairs appropriately in net/disk_cache/memory (Closed)

Created:
5 years, 7 months ago by payal.pandey
Modified:
5 years, 7 months ago
Reviewers:
eroman, Peter Kasting
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use of base::StringPairs appropriately in net/disk_cache/memory Bescause base/strings/string_split.h defines: typedef std::vector<std::pair<std::string, std::string> > StringPairs; BUG=412250 Committed: https://crrev.com/d7c48d4e809ef3c6864083d9de3b4fe0aaffc8cf Cr-Commit-Position: refs/heads/master@{#328255}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixed Compilation issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/disk_cache/memory/mem_backend_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
payal.pandey
Please have a look, Thanks.
5 years, 7 months ago (2015-05-01 10:32:04 UTC) #2
Peter Kasting
https://codereview.chromium.org/1118953002/diff/1/net/disk_cache/memory/mem_backend_impl.h File net/disk_cache/memory/mem_backend_impl.h (left): https://codereview.chromium.org/1118953002/diff/1/net/disk_cache/memory/mem_backend_impl.h#oldcode84 net/disk_cache/memory/mem_backend_impl.h:84: std::vector<std::pair<std::string, std::string>>* stats) override {} Why are you changing ...
5 years, 7 months ago (2015-05-01 11:18:46 UTC) #4
eroman
https://codereview.chromium.org/1118953002/diff/1/net/disk_cache/memory/mem_backend_impl.h File net/disk_cache/memory/mem_backend_impl.h (right): https://codereview.chromium.org/1118953002/diff/1/net/disk_cache/memory/mem_backend_impl.h#newcode12 net/disk_cache/memory/mem_backend_impl.h:12: #include "base/memory/wieak_ptr.h" On 2015/05/01 11:18:46, Peter Kasting wrote: > ...
5 years, 7 months ago (2015-05-02 01:14:32 UTC) #5
payal.pandey
On 2015/05/02 01:14:32, eroman wrote: > https://codereview.chromium.org/1118953002/diff/1/net/disk_cache/memory/mem_backend_impl.h > File net/disk_cache/memory/mem_backend_impl.h (right): > > https://codereview.chromium.org/1118953002/diff/1/net/disk_cache/memory/mem_backend_impl.h#newcode12 > ...
5 years, 7 months ago (2015-05-04 10:25:23 UTC) #6
Peter Kasting
You didn't respond to any of the other comments I made. This doesn't demonstrate appropriate ...
5 years, 7 months ago (2015-05-04 13:10:25 UTC) #7
payal.pandey
On 2015/05/04 13:10:25, Peter Kasting wrote: > You didn't respond to any of the other ...
5 years, 7 months ago (2015-05-04 13:32:26 UTC) #8
Peter Kasting
On 2015/05/04 13:32:26, payal.pandey wrote: > On 2015/05/04 13:10:25, Peter Kasting wrote: > > You ...
5 years, 7 months ago (2015-05-04 18:48:44 UTC) #9
payal.pandey
@Peter : Not at all any trouble. Its good to learn as am newbee to ...
5 years, 7 months ago (2015-05-04 19:11:37 UTC) #10
eroman
lgtm
5 years, 7 months ago (2015-05-04 20:22:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118953002/20001
5 years, 7 months ago (2015-05-05 00:59:47 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-05 02:49:58 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 02:51:54 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d7c48d4e809ef3c6864083d9de3b4fe0aaffc8cf
Cr-Commit-Position: refs/heads/master@{#328255}

Powered by Google App Engine
This is Rietveld 408576698