Use of base::StringPairs appropriately in net/disk_cache/memory

Use of base::StringPairs appropriately in  net/disk_cache/memory

Bescause base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250
Committed: https://crrev.com/d7c48d4e809ef3c6864083d9de3b4fe0aaffc8cf
Cr-Commit-Position: refs/heads/master@{#328255}

[payal.pandey, 2015-05-01 10:32:04]

payal.pandey@samsung.com changed reviewers:
+ eroman@chromium.org

[payal.pandey, 2015-05-01 10:32:04]

Please have a look, Thanks.

[Peter Kasting, 2015-05-01 11:18:46]

pkasting@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2015-05-01 11:18:46]

https://codereview.chromium.org/1118953002/diff/1/net/disk_cache/memory/mem_b...
File net/disk_cache/memory/mem_backend_impl.h (left):

https://codereview.chromium.org/1118953002/diff/1/net/disk_cache/memory/mem_b...
net/disk_cache/memory/mem_backend_impl.h:84: std::vector<std::pair<std::string,
std::string>>* stats) override {}
Why are you changing this specific subclass, but not the base class (and any
other related classes)?

Why are you only changing the header, and not the .cc file?

https://codereview.chromium.org/1118953002/diff/1/net/disk_cache/memory/mem_b...
File net/disk_cache/memory/mem_backend_impl.h (right):

https://codereview.chromium.org/1118953002/diff/1/net/disk_cache/memory/mem_b...
net/disk_cache/memory/mem_backend_impl.h:12: #include "base/memory/wieak_ptr.h"
You seem to have introduced a typo here, did you try to compile this?

[eroman, 2015-05-02 01:14:32]

https://codereview.chromium.org/1118953002/diff/1/net/disk_cache/memory/mem_b...
File net/disk_cache/memory/mem_backend_impl.h (right):

https://codereview.chromium.org/1118953002/diff/1/net/disk_cache/memory/mem_b...
net/disk_cache/memory/mem_backend_impl.h:12: #include "base/memory/wieak_ptr.h"
On 2015/05/01 11:18:46, Peter Kasting wrote:
> You seem to have introduced a typo here, did you try to compile this?

Same question as Peter here.

[payal.pandey, 2015-05-04 10:25:23]

On 2015/05/02 01:14:32, eroman wrote:
>
https://codereview.chromium.org/1118953002/diff/1/net/disk_cache/memory/mem_b...
> File net/disk_cache/memory/mem_backend_impl.h (right):
> 
>
https://codereview.chromium.org/1118953002/diff/1/net/disk_cache/memory/mem_b...
> net/disk_cache/memory/mem_backend_impl.h:12: #include
"base/memory/wieak_ptr.h"
> On 2015/05/01 11:18:46, Peter Kasting wrote:
> > You seem to have introduced a typo here, did you try to compile this?
> 
> Same question as Peter here.

@eroman & @Peter : It was a typo error, which got included while using vim
editor to verify for correct change after compilation.
Please review the CL, Thanks.

[Peter Kasting, 2015-05-04 13:10:25]

You didn't respond to any of the other comments I made.  This doesn't
demonstrate appropriate attention to detail.

Please look at everything I asked, and only send this patch back if and when you
implement a comprehensive and consistent solution that doesn't amount to a
random type change in an arbitrary file.

[payal.pandey, 2015-05-04 13:32:26]

On 2015/05/04 13:10:25, Peter Kasting wrote:
> You didn't respond to any of the other comments I made.  This doesn't
> demonstrate appropriate attention to detail.
> 
> Please look at everything I asked, and only send this patch back if and when
you
> implement a comprehensive and consistent solution that doesn't amount to a
> random type change in an arbitrary file.

Hi Peter,

I already changed in all classes, wherever td::vector<std::pair<std::string,
std::string> > is being used.
Also in all the GetStats() overridden function.

Please brief where else its been left.

Thanks.

[Peter Kasting, 2015-05-04 18:48:44]

On 2015/05/04 13:32:26, payal.pandey wrote:
> On 2015/05/04 13:10:25, Peter Kasting wrote:
> > You didn't respond to any of the other comments I made.  This doesn't
> > demonstrate appropriate attention to detail.
> > 
> > Please look at everything I asked, and only send this patch back if and when
> you
> > implement a comprehensive and consistent solution that doesn't amount to a
> > random type change in an arbitrary file.
> 
> Hi Peter,
> 
> I already changed in all classes, wherever td::vector<std::pair<std::string,
> std::string> > is being used.
> Also in all the GetStats() overridden function.
> 
> Please brief where else its been left.

OK... I think when I checked on Friday, codesearch hadn't been updated with the
three previous CLs you landed for this.  That's why I hadn't seen any of this
done.

In the future, it might be best to do all such changes as part of a single CL --
they're still small enough as a group to be easily reviewable, and it will
definitely be simpler conceptually.

Since it looks like this is the last such remaining place, I withdraw my
objections.  I'll let Eric do the formal signoff as I'm not a net/ owner.  Sorry
for the trouble!

[payal.pandey, 2015-05-04 19:11:37]

@Peter : Not at all any trouble. 
Its good to learn as am newbee to Open source community.
So everything is a piece of information.
Thanks for reviewing.

@Eroman: please have a look, Thanks.

[eroman, 2015-05-04 20:22:50]

lgtm

[payal.pandey, 2015-05-05 00:58:05]

The CQ bit was checked by payal.pandey@samsung.com

[commit-bot: I haz the power, 2015-05-05 00:59:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1118953002/20001

[commit-bot: I haz the power, 2015-05-05 02:49:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-05 02:51:54]

Patchset 2 (id:??) landed as
https://crrev.com/d7c48d4e809ef3c6864083d9de3b4fe0aaffc8cf
Cr-Commit-Position: refs/heads/master@{#328255}