Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: runtime/lib/array_patch.dart

Issue 11189141: Move ListImplementation from coreimpl to core, as a private member. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix a case in x64. Passes all tests on x64 now. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/array_patch.dart
diff --git a/runtime/lib/array_patch.dart b/runtime/lib/array_patch.dart
index b84904b16b378a365bf39f381310912db9d01a43..01d2e1f2bf58c4511106feb983b34ab51a6a14aa 100644
--- a/runtime/lib/array_patch.dart
+++ b/runtime/lib/array_patch.dart
@@ -5,7 +5,7 @@
// Note that the optimizing compiler depends on the algorithm which
// returns a _GrowableObjectArray if length is null, otherwise returns
// fixed size array.
-patch class ListImplementation<E> {
+patch class _ListImpl<E> {
/* patch */ factory List([int length = null]) {
if (length === null) {
return new _GrowableObjectArray<E>();
@@ -14,8 +14,8 @@ patch class ListImplementation<E> {
}
}
- /* patch */ static _from(Iterable other) {
- _GrowableObjectArray list = new _GrowableObjectArray();
+ /* patch */ factory List.from(Iterable<E> other) {
+ var list = new _GrowableObjectArray<E>();
for (final e in other) {
list.add(e);
}

Powered by Google App Engine
This is Rietveld 408576698