Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 11189113: Prepare push to trunk. Now working on version 3.14.6. (Closed)

Created:
8 years, 2 months ago by rossberg
Modified:
8 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Prepare push to trunk. Now working on version 3.14.6. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=12786

Patch Set 1 #

Total comments: 14
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M ChangeLog View 1 chunk +25 lines, -0 lines 14 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
8 years, 2 months ago (2012-10-22 12:25:44 UTC) #1
Jakob Kummerow
LGTM with comments. https://codereview.chromium.org/11189113/diff/1/ChangeLog File ChangeLog (right): https://codereview.chromium.org/11189113/diff/1/ChangeLog#newcode3 ChangeLog:3: Kill off the SCons based build. ...
8 years, 2 months ago (2012-10-22 12:42:12 UTC) #2
rossberg
8 years, 2 months ago (2012-10-22 13:04:22 UTC) #3
https://codereview.chromium.org/11189113/diff/1/ChangeLog
File ChangeLog (right):

https://codereview.chromium.org/11189113/diff/1/ChangeLog#newcode3
ChangeLog:3: Kill off the SCons based build.
On 2012/10/22 12:42:12, Jakob wrote:
> nit: past tense please

Done.

https://codereview.chromium.org/11189113/diff/1/ChangeLog#newcode5
ChangeLog:5: Add a faster API for creating v8::Integer objects.
On 2012/10/22 12:42:12, Jakob wrote:
> nit: past tense please

Done.

https://codereview.chromium.org/11189113/diff/1/ChangeLog#newcode7
ChangeLog:7: Speed up function deoptimization by avoiding quadratic pass over
On 2012/10/22 12:42:12, Jakob wrote:
> nit: past tense please

Done.

https://codereview.chromium.org/11189113/diff/1/ChangeLog#newcode13
ChangeLog:13: Fixed json regression. (issue 2374)
On 2012/10/22 12:42:12, Jakob wrote:
> This regression was only introduced after the last push to trunk, so there is
no
> need to mention it.

Done.

https://codereview.chromium.org/11189113/diff/1/ChangeLog#newcode15
ChangeLog:15: Fixed error introduced in r12761. (issue 2373)
On 2012/10/22 12:42:12, Jakob wrote:
> Same here -- r12761 is younger than 3.14.4, no need to mention it.

Done.

https://codereview.chromium.org/11189113/diff/1/ChangeLog#newcode17
ChangeLog:17: Revert recent CPU profiler changes because they broke --prof.
On 2012/10/22 12:42:12, Jakob wrote:
> nit: past tense please

Done.

https://codereview.chromium.org/11189113/diff/1/ChangeLog#newcode20
ChangeLog:20: Switch code flushing to use different JSFunction field.
On 2012/10/22 12:42:12, Jakob wrote:
> nit: past tense please

Done.

Powered by Google App Engine
This is Rietveld 408576698