Changing minidump process generation to be in-process on Android.

content/browser/renderer_host/render_process_host_impl.cc

Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 329140c928080693e310fa9aafbe4c5cb3fe1695..546c717a7b14c35e50b013ae7cf9778975494724 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -495,7 +495,8 @@ bool RenderProcessHostImpl::Init() {
 #endif
     in_process_renderer_->StartWithOptions(options);
 
-    OnProcessLaunched();  // Fake a callback that the process is ready.
+    // Fake a callback that the process is ready.
+    OnProcessLaunched(content::FDInfoList());
   } else {
     // Build command line for renderer.  We call AppendRendererCommandLine()
     // first so the process type argument will appear first.
@@ -1535,7 +1536,8 @@ void RenderProcessHostImpl::SetBackgrounded(bool backgrounded) {
   child_process_launcher_->SetProcessBackgrounded(backgrounded);
 }
 
-void RenderProcessHostImpl::OnProcessLaunched() {
+void RenderProcessHostImpl::OnProcessLaunched(
+      const content::FDInfoList& mapped_files) {
   // No point doing anything, since this object will be destructed soon.  We
   // especially don't want to send the RENDERER_PROCESS_CREATED notification,
   // since some clients might expect a RENDERER_PROCESS_TERMINATED afterwards to
@@ -1562,7 +1564,7 @@ void RenderProcessHostImpl::OnProcessLaunched() {
   NotificationService::current()->Notify(
       NOTIFICATION_RENDERER_PROCESS_CREATED,
       Source<RenderProcessHost>(this),
-      NotificationService::NoDetails());
+      Details<const content::FDInfoList>(&mapped_files));

[jam, 2012/10/19 16:39:17]

this seems awkward for two reasons:
-it adds seemingly unrelated data to that notification (even though I understand
why you're doing it this way)
-it gives the embedder information (file mapping) that the embedder originally
gave content.

it seems that the ContentBrowserClient::GetAdditionalMappedFilesForChildProcess
call should just be changed to take the child_process_id so that it can
associate the mapping to the process that way.

[Jay Civelli, 2012/10/22 22:09:48]

Changed per our discussion. Now using the process host ID in the crash handler.

 
   while (!queued_messages_.empty()) {
     Send(queued_messages_.front());