Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: chrome/browser/chrome_browser_main_android.cc

Issue 11189068: Changing minidump process generation to be in-process on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_main_android.cc
diff --git a/chrome/browser/chrome_browser_main_android.cc b/chrome/browser/chrome_browser_main_android.cc
index d99c140119ddc3fbe21243d2de8fcbfaa9424906..05d74193ab0b485a5a758bc5b8b3f70c49c52651 100644
--- a/chrome/browser/chrome_browser_main_android.cc
+++ b/chrome/browser/chrome_browser_main_android.cc
@@ -4,7 +4,7 @@
#include "chrome/browser/chrome_browser_main_android.h"
-#include "chrome/common/chrome_switches.h"
+#include "chrome/app/breakpad_linux.h"
#include "content/public/common/main_function_params.h"
#include "net/android/network_change_notifier_factory_android.h"
#include "net/base/network_change_notifier.h"
@@ -17,6 +17,18 @@ ChromeBrowserMainPartsAndroid::ChromeBrowserMainPartsAndroid(
ChromeBrowserMainPartsAndroid::~ChromeBrowserMainPartsAndroid() {
}
+void ChromeBrowserMainPartsAndroid::PreProfileInit() {
+#if defined(USE_LINUX_BREAKPAD)
+ // TODO(jcivelli): we should not initialize the crash-reporter when it was not
+ // enabled. Right now if it is disabled we still generate the minidumps but we
+ // do not upload them.
+ InitCrashReporter();
+#endif
+
+ ChromeBrowserMainParts::PreProfileInit();
+}
+
jam 2012/10/23 01:20:47 nit: extra line
Jay Civelli 2012/10/23 20:39:55 Done.
+
void ChromeBrowserMainPartsAndroid::PreEarlyInitialization() {
net::NetworkChangeNotifier::SetFactory(
new net::NetworkChangeNotifierFactoryAndroid());

Powered by Google App Engine
This is Rietveld 408576698