Changing minidump process generation to be in-process on Android.

chrome/browser/android/crash_dump_manager.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_ANDROID_CRASH_DUMP_MANAGER_H_
+#define CHROME_BROWSER_ANDROID_CRASH_DUMP_MANAGER_H_
+
+#include <map>
+
+#include "base/file_path.h"
+#include "base/memory/singleton.h"

[Lei Zhang, 2012/10/23 02:57:34]

nit: unused

[Jay Civelli, 2012/10/23 20:39:55]

Done.

+#include "base/platform_file.h"
+#include "base/synchronization/lock.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
+
+namespace content {
+class RenderProcessHost;
+}
+
+// This class manages the crash minidumps.
+// On Android, because of process isolation, each renderer process runs with a
+// different UID. As a result, we cannot generate the minidumps in the browser
+// (as the browser process does not have access to some system files for the
+// crashed process). So the minidump is generated in the renderer process.
+// Since the isolated process cannot open files, we provide it on creation with
+// a file descriptor where to write the minidump in the event of a crash.
+// This class creates these file descriptors and associates them with render
+// processes and take the appropriate action when the render process terminates.
+class CrashDumpManager : public content::NotificationObserver {
+ public:
+  // Should be created on the UI thread.
+  CrashDumpManager();
+  virtual ~CrashDumpManager();
+
+  // Returns a file descriptor that should be used to generate a minidump for
+  // the process |process_host_id|.
+  int CreateMinidumpFile(int process_host_id);
+
+ private:
+  struct MinidumpInfo {
+    MinidumpInfo() : file(base::kInvalidPlatformFileValue) {}
+    base::PlatformFile file;
+    FilePath path;
+    int pid;
+  };
+
+  static void ProcessMinidump(const MinidumpInfo& minidump);
+
+  // NotificationObserver implementation:
+  virtual void Observe(int type,
+                       const content::NotificationSource& source,
+                       const content::NotificationDetails& details) OVERRIDE;
+
+  content::NotificationRegistrar notification_registrar_;
+
+  // This map should only be accessed with its lock aquired as it is accessed
+  // from the PROCESS_LAUNCHER and UI threads.
+  base::Lock process_host_id_to_minidump_info_lock_;
+  typedef std::map<int, MinidumpInfo> ProcessHostIDToMinidumpInfo;

[Lei Zhang, 2012/10/23 02:57:34]

nit: goes near the top of the private section, not right before the first use.

[Jay Civelli, 2012/10/23 20:39:55]

Done.

+  ProcessHostIDToMinidumpInfo process_host_id_to_minidump_info_;
+
+  DISALLOW_COPY_AND_ASSIGN(CrashDumpManager);
+};
+
+#endif  // CHROME_BROWSER_ANDROID_CRASH_DUMP_MANAGER_H_