Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 11189032: Delete old forwarder. (Closed)

Created:
8 years, 2 months ago by felipeg
Modified:
3 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Delete old forwarder. Since we moved to the new forwarder implementation we can delete this. BUG=146502

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -470 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
D tools/android/forwarder/forwarder.cc View 1 chunk +0 lines, -426 lines 0 comments Download
D tools/android/forwarder/forwarder.gyp View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bulach
lgtm, yay! thanks!
8 years, 2 months ago (2012-10-18 10:00:55 UTC) #1
felipeg
FYI, this change will need to wait a little bit, since we are still using ...
8 years, 2 months ago (2012-10-18 10:03:28 UTC) #2
Philippe
lgtm, thanks Felipe!
8 years, 2 months ago (2012-10-18 10:08:44 UTC) #3
Yaron
Can this land yet or still some stray deps?
7 years, 11 months ago (2013-01-08 01:06:15 UTC) #4
digit1
lgtm
7 years, 11 months ago (2013-01-08 09:37:52 UTC) #5
Philippe
On 2013/01/08 09:37:52, digit1 wrote: > lgtm Forwarder1 is still being used in WebKit. I ...
7 years, 11 months ago (2013-01-08 09:41:06 UTC) #6
Yaron
On 2013/01/08 09:41:06, Philippe wrote: > On 2013/01/08 09:37:52, digit1 wrote: > > lgtm > ...
7 years, 8 months ago (2013-04-18 01:00:36 UTC) #7
Peter Beverloo
Philippe unfortunately never finished his work on moving to forwarder2 in WebKit. I'll update Blink's ...
7 years, 8 months ago (2013-04-23 13:50:58 UTC) #8
Philippe
On 2013/04/23 13:50:58, Peter Beverloo wrote: > Philippe unfortunately never finished his work on moving ...
7 years, 8 months ago (2013-04-23 14:05:05 UTC) #9
felipeg
7 years, 8 months ago (2013-04-26 12:47:33 UTC) #10
On 2013/04/23 14:05:05, Philippe wrote:
> On 2013/04/23 13:50:58, Peter Beverloo wrote:
> > Philippe unfortunately never finished his work on moving to forwarder2 in
> > WebKit.  I'll update Blink's layout test runner shortly and will report back
> > here when that's done.
> 
> Yes unfortunately. I preferred to postpone the migration slightly while m25
was
> being stabilized given the debugging/maintenance cost that would happen with
the
> migration. The transition in Chromium from forwarder1 to forwarder2 hasn't
been
> totally seamless as you probably noticed :) Now that we moved to Blink it will
> be easier for me to continue this work.

My Kudos to Philippe, for taking this dirty work that no one else wanted to do
:)

Powered by Google App Engine
This is Rietveld 408576698