Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 11189018: Fix build of mini_installer with VS2012 (Closed)

Created:
8 years, 2 months ago by cpu_(ooo_6.6-7.5)
Modified:
8 years, 2 months ago
Reviewers:
robertshield
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield%chromium.org
Visibility:
Public.

Description

Fix build of mini_installer with VS2012 BUG=143646 TEST= mini_installer (with branding=chrome) builds Here is the error: t0\src>ninja -C out\Debug mini_installer [1/9] CXX obj\chrome_frame\npchrome_frame.chrome_tab.obj FAILED: ninja -t msvc -r . -o obj\chrome_frame\npchrome_frame.chrome_tab.obj -e environment.x86 -- cl.exe ... .. microsoft visual studio 11.0\vc\atlmfc\include\atlbase.h(2845) : error C2338: 'CAtlDllModuleT<T>' must be used with either _WINDLL or _USRDLL defined ..\microsoft visual studio 11.0\vc\atlmfc\include\atlbase.h(3298) : see reference to class template instantiation 'ATL::CAtlValidateModuleConfiguration<isDllModule,T>' being compiled with [ isDllModule=true, T=`anonymous-namespace'::ChromeTabModule ] t0\src\chrome_frame\chrome_tab.cc(98) : see reference to class template instantiation 'ATL::CAtlDllModuleT<T>' being compiled with [ T=`anonymous-namespace'::ChromeTabModule ] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162291

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome_frame/chrome_frame.gyp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
cpu_(ooo_6.6-7.5)
8 years, 2 months ago (2012-10-16 22:26:03 UTC) #1
robertshield
8 years, 2 months ago (2012-10-17 00:31:05 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698