Issue 11189002: Makes notifications animate from the bottom of the screen (as was

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11189002: Makes notifications animate from the bottom of the screen (as was (Closed)

Created:
8 years, 2 months ago by sky

Modified:
8 years, 2 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Makes notifications animate from the bottom of the screen (as was intended) instead of the upper left corner. TEST=see bug BUG=152727 R=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162292

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -23 lines)			Patch
M	chrome/browser/notifications/balloon.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection_impl.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/notifications/balloon_view_views.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/notifications/balloon_view_views.cc	View	7 chunks	+20 lines, -22 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

8 years, 2 months ago (2012-10-16 17:28:59 UTC) #4

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/11189002/1