Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: BUILD.gn

Issue 1118863002: Port Chromium's blink_tests target to GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: host_toolchain Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 7f497fa984a3f977d502f857473a953adc45e8da..0eca77359aed95b291b13993c7609fd9fa5e42c8 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -719,6 +719,51 @@ group("gn_visibility") {
]
}
+if (!is_ios) {
+ group("blink_tests") {
+ testonly = true
+
+ deps = [
+ "//third_party/WebKit/public:blink_tests",
+ ]
+
+ if (is_android) {
+ deps += [
+ "//breakpad:dump_syms($host_toolchain)",
+ "//breakpad:minidump_stackwalk($host_toolchain)",
+ "//content/shell/android:content_shell_apk",
+ ]
+ } else {
+ deps += [ "//content/shell:content_shell" ]
+ }
+
+ if (is_win) {
+ deps += [
+ #'../content/content_shell_and_tests.gyp:content_shell_crash_service',
+ #'../content/content_shell_and_tests.gyp:layout_test_helper',
Dirk Pranke 2015/05/01 19:55:03 maybe add TODO(GYP)'s for these?
tfarina 2015/05/01 21:32:31 Done.
+ ]
+ }
+
+ if (!is_win && !is_android) {
+ deps += [ "//breakpad:minidump_stackwalk" ]
+ }
+
+ if (is_mac) {
+ deps += [
+ "//breakpad:dump_syms($host_toolchain)",
+ #'../content/content_shell_and_tests.gyp:layout_test_helper',
+ ]
+ }
+
+ if (is_linux) {
+ deps += [
+ "//breakpad:dump_syms($host_toolchain)",
+ #'../breakpad/breakpad.gyp:dump_syms#host'
Dirk Pranke 2015/05/01 19:55:03 I think you can delete line 761, right?
tfarina 2015/05/01 21:32:31 Done.
+ ]
+ }
+ }
+}
+
if (is_linux) {
# This group corresponds to the list of tests run on the waterfall for
# desktop Linux GYP builds from testing/buildbot/chromium.linux.json. It's
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698