Port Chromium's blink_tests target to GN.

BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This is the root build file for GN. GN will start processing by loading this
 # file, and recursively load all dependencies until all dependencies are either
 # resolved or known not to exist (which will cause the build to fail). So if
 # you add a new build file, there must be some path of dependencies from this
 # file to your new one or GN won't know about it.
 
@@ skipping 114 matching lines @@
     "//ppapi/examples/threading",
     "//ppapi/examples/url_loader",
     "//ppapi/examples/video_capture",
     "//ppapi/examples/video_decode",
     "//ppapi/examples/video_effects",
     "//ppapi/examples/video_encode",
     "//printing:printing_unittests",
     "//skia:skia_unittests",
     "//sql:sql_unittests",
     "//sync:sync_unit_tests",
-    "//third_party/WebKit/public:blink_tests",
+    "//third_party/WebKit/Source/platform:heap_unittests",
+    "//third_party/WebKit/Source/platform:platform_unittests",
+    "//third_party/WebKit/Source/web:webkit_unit_tests",
+    "//third_party/WebKit/Source/wtf:wtf_unittests",
     "//third_party/cacheinvalidation:cacheinvalidation_unittests",
     "//third_party/codesighs",
     "//third_party/mojo/src/mojo/edk/system:mojo_system_unittests",
     "//third_party/mojo/src/mojo/edk/test:mojo_public_bindings_unittests",
     "//third_party/mojo/src/mojo/edk/test:mojo_public_environment_unittests",
     "//third_party/mojo/src/mojo/edk/test:mojo_public_system_unittests",
     "//third_party/mojo/src/mojo/edk/test:mojo_public_utility_unittests",
     "//third_party/pdfium/samples:pdfium_test",
     "//third_party/smhasher:pmurhash",
     "//tools/imagediff($host_toolchain)",
@@ skipping 389 matching lines @@
       "//chrome/test:interactive_ui_tests",  # TODO(GYP)
       "//chrome/test:sync_integration_tests",  # TODO(GYP)
       "//chrome/test:unit_tests",  # TODO(GYP)
       "//components:components_browsertests",  # TODO(GYP)
       "//components:components_unittests",  # TODO(GYP)
       "//content/test:content_browsertests",  # TODO(GYP)
       "//content/test:content_perftests",  # TODO(GYP)
       "//extensions:extensions_browsertests",  # TODO(GYP)
       "//extensions:extensions_unittests",  # TODO(GYP)
       "//net:net_unittests",  # TODO(GYP)
+
+      # TODO(GYP): Re-enable this as soon as we can link Blink binaries on mac.
+      "//third_party/WebKit/Source/platform:heap_unittests",
+      "//third_party/WebKit/Source/platform:platform_unittests",
+      "//third_party/WebKit/Source/web:webkit_unit_tests",
       "//ui/app_list:app_list_unittests",  # TODO(GYP)
       "//ui/gfx:gfx_unittests",  # TODO(GYP)
     ]
   }
 
   if (is_win) {
     deps += [
       "//base:pe_image_test",
       "//chrome_elf:chrome_elf_unittests",
       "//chrome_elf:dll_hash_main",
@@ skipping 157 matching lines @@
     # "//third_party/pdfium:pdfium_embeddertests",  # TODO(GYP): visibility?
     # "//third_party/pdfium:pdfium_unittests",  # TODO(GYP): visibility?
 
     "//ui/resources:repack_ui_test_mac_locale_pack",
 
     # "//v8:v8_snapshot",  # TODO(GYP): visibility?
     # "//v8:postmortem-metadata",  # TODO(GYP): visibility?
   ]
 }
 
+if (!is_ios) {
+  group("blink_tests") {
+    testonly = true
+
+    deps = [
+      "//third_party/WebKit/Source/platform:heap_unittests",
+      "//third_party/WebKit/Source/platform:platform_unittests",
+      "//third_party/WebKit/Source/web:webkit_unit_tests",
+      "//third_party/WebKit/Source/wtf:wtf_unittests",
+    ]
+
+    # NOTE: The following deps are needed to run the layout tests.

[brettw, 2015/05/08 16:57:04]

If this comment is literally true, then the layout test targets themselves
should have data_deps on these targets. And actually, I don't see layout tests
in this target, it looks only like unit tests.

My understanding was that the way the bots run these tests it expects these
targets to exist. But if I do "ninja webkit_unit_tests" and then run the tests,
they're not required. If this understanding is correct, then the comment should
say "The bots expect the following targets to exist to run the test
environment." or something. If particular tests have particular requirements,
those requirements should be on those tests.

[tfarina, 2015/05/08 17:03:51]

My understanding is that this target (blink_tests) is built for when you run
third_party/WebKit/Tools/Scripts/run-webkit-tests

+    if (is_android) {
+      deps += [
+        "//breakpad:dump_syms($host_toolchain)",
+        "//breakpad:minidump_stackwalk($host_toolchain)",
+        "//content/shell/android:content_shell_apk",
+      ]
+    } else {
+      deps += [ "//content/shell:content_shell" ]
+    }
+
+    if (is_win) {
+      deps += [
+        #'../content/content_shell_and_tests.gyp:content_shell_crash_service', TODO(GYP)
+        #'../content/content_shell_and_tests.gyp:layout_test_helper', TODO(GYP)
+      ]
+    }
+
+    if (!is_win && !is_android) {
+      deps += [ "//breakpad:minidump_stackwalk" ]
+    }
+
+    if (is_mac) {
+      deps += [
+        "//breakpad:dump_syms($host_toolchain)",
+        #'../content/content_shell_and_tests.gyp:layout_test_helper', TODO(GYP)
+      ]
+
+      # TODO(GYP): Re-enable this as soon as we can link Blink binaries on mac.
+      deps -= [
+        "//third_party/WebKit/Source/platform:heap_unittests",
+        "//third_party/WebKit/Source/platform:platform_unittests",
+        "//third_party/WebKit/Source/web:webkit_unit_tests",
+      ]
+    }
+
+    if (is_linux) {
+      deps += [ "//breakpad:dump_syms($host_toolchain)" ]
+    }
+  }
+}
+
 if (is_linux) {
   # This group corresponds to the list of tests run on the waterfall for
   # desktop Linux GYP builds from testing/buildbot/chromium.linux.json. It's
   # here to help track GYP -> GN conversion progress.
   group("linux_default_tests") {
     testonly = true
     deps = [
       "//base:base_unittests",  # PASSES (*) 2/25/2015
       "//cc:cc_unittests",  # PASSES 2/25/2015
       "//chrome/test:browser_tests",
@@ skipping 121 matching lines @@
       "//ui/views:views_unittests",  # TooltipControllerTest failures
       "//ui/wm:wm_unittests",  # PASSES 4/21/2015
       "//url:url_unittests",  # PASSES 4/17/2015
 
       # TODO(GYP) nacl_integration
       # TODO(GYP) telemetry_perf_unittests
       # TODO(GYP) telemetry_unittests
     ]
   }
 }