Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/remoting/protocol/pairing_registry.cc

Issue 111883004: Revert 239921 "Revert 239759 "The comment in base64.h implies th..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/remoting/protocol/authenticator_test_base.cc ('k') | trunk/src/remoting/protocol/v2_authenticator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/remoting/protocol/pairing_registry.cc
===================================================================
--- trunk/src/remoting/protocol/pairing_registry.cc (revision 239942)
+++ trunk/src/remoting/protocol/pairing_registry.cc (working copy)
@@ -49,10 +49,8 @@
std::string shared_secret;
char buffer[kKeySize];
crypto::RandBytes(buffer, arraysize(buffer));
- if (!base::Base64Encode(base::StringPiece(buffer, arraysize(buffer)),
- &shared_secret)) {
- LOG(FATAL) << "Base64Encode failed.";
- }
+ base::Base64Encode(base::StringPiece(buffer, arraysize(buffer)),
+ &shared_secret);
return Pairing(created_time, client_name, client_id, shared_secret);
}
« no previous file with comments | « trunk/src/remoting/protocol/authenticator_test_base.cc ('k') | trunk/src/remoting/protocol/v2_authenticator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698