Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1726)

Unified Diff: trunk/src/net/http/http_auth_handler_basic.cc

Issue 111883004: Revert 239921 "Revert 239759 "The comment in base64.h implies th..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/net/http/http_auth_gssapi_posix.cc ('k') | trunk/src/net/http/http_auth_handler_ntlm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/net/http/http_auth_handler_basic.cc
===================================================================
--- trunk/src/net/http/http_auth_handler_basic.cc (revision 239942)
+++ trunk/src/net/http/http_auth_handler_basic.cc (working copy)
@@ -91,13 +91,9 @@
DCHECK(credentials);
// TODO(eroman): is this the right encoding of username/password?
std::string base64_username_password;
- if (!base::Base64Encode(
- UTF16ToUTF8(credentials->username()) + ":" +
- UTF16ToUTF8(credentials->password()),
- &base64_username_password)) {
- LOG(ERROR) << "Unexpected problem Base64 encoding.";
- return ERR_UNEXPECTED;
- }
+ base::Base64Encode(UTF16ToUTF8(credentials->username()) + ":" +
+ UTF16ToUTF8(credentials->password()),
+ &base64_username_password);
*auth_token = "Basic " + base64_username_password;
return OK;
}
« no previous file with comments | « trunk/src/net/http/http_auth_gssapi_posix.cc ('k') | trunk/src/net/http/http_auth_handler_ntlm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698