Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: trunk/src/chrome/browser/extensions/extension_protocols.cc

Issue 111883004: Revert 239921 "Revert 239759 "The comment in base64.h implies th..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/extensions/extension_protocols.cc
===================================================================
--- trunk/src/chrome/browser/extensions/extension_protocols.cc (revision 239942)
+++ trunk/src/chrome/browser/extensions/extension_protocols.cc (working copy)
@@ -86,15 +86,14 @@
last_modified_time.ToInternalValue());
hash = base::SHA1HashString(hash);
std::string etag;
- if (base::Base64Encode(hash, &etag)) {
- raw_headers.append(1, '\0');
- raw_headers.append("ETag: \"");
- raw_headers.append(etag);
- raw_headers.append("\"");
- // Also force revalidation.
- raw_headers.append(1, '\0');
- raw_headers.append("cache-control: no-cache");
- }
+ base::Base64Encode(hash, &etag);
+ raw_headers.append(1, '\0');
+ raw_headers.append("ETag: \"");
+ raw_headers.append(etag);
+ raw_headers.append("\"");
+ // Also force revalidation.
+ raw_headers.append(1, '\0');
+ raw_headers.append("cache-control: no-cache");
}
raw_headers.append(2, '\0');

Powered by Google App Engine
This is Rietveld 408576698