Revert 239921 "Revert 239759 "The comment in base64.h implies th..."

trunk/src/extensions/common/extension.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/extension.h"
 
 #include "base/base64.h"
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ skipping 230 matching lines @@
     if (working.length() == 0)
       return false;
   }
 
   return base::Base64Decode(working, output);
 }
 
 // static
 bool Extension::ProducePEM(const std::string& input, std::string* output) {
   DCHECK(output);
-  return (input.length() == 0) ? false : base::Base64Encode(input, output);
+  if (input.empty())
+    return false;
+  base::Base64Encode(input, output);
+  return true;
 }
 
 // static
 bool Extension::FormatPEMForFileOutput(const std::string& input,
                                        std::string* output,
                                        bool is_public) {
   DCHECK(output);
   if (input.length() == 0)
     return false;
   *output = "";
@@ skipping 522 matching lines @@
 
 UpdatedExtensionPermissionsInfo::UpdatedExtensionPermissionsInfo(
     const Extension* extension,
     const PermissionSet* permissions,
     Reason reason)
     : reason(reason),
       extension(extension),
       permissions(permissions) {}
 
 }   // namespace extensions