make drawImage a virtual on SkDevice

make drawImage a virtual on SkDevice

default impl will turn the Image into a (raster) bitmap and call drawBitmap.

BUG=skia:3803
Committed: https://skia.googlesource.com/skia/+/f603fb3d0e5fa57c3f228d66945bef198b001135

[reed1, 2015-05-04 14:49:41]

reed@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[reed1, 2015-05-04 14:50:09]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-05-04 14:50:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1118823004/20001

[commit-bot: I haz the power, 2015-05-04 14:55:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-04 14:55:46]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-05-04 14:56:15]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-05-04 14:56:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1118823004/40001

[commit-bot: I haz the power, 2015-05-04 15:05:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-04 15:05:09]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2015-05-04 15:08:07]

lgtm

https://codereview.chromium.org/1118823004/diff/40001/include/core/SkDevice.h
File include/core/SkDevice.h (right):

https://codereview.chromium.org/1118823004/diff/40001/include/core/SkDevice.h...
include/core/SkDevice.h:212: virtual void drawImage(const SkDraw&, const
SkImage*, SkScalar x, SkScalar y, const SkPaint&);
override?

[reed1, 2015-05-04 15:11:21]

https://codereview.chromium.org/1118823004/diff/40001/include/core/SkDevice.h
File include/core/SkDevice.h (right):

https://codereview.chromium.org/1118823004/diff/40001/include/core/SkDevice.h...
include/core/SkDevice.h:212: virtual void drawImage(const SkDraw&, const
SkImage*, SkScalar x, SkScalar y, const SkPaint&);
On 2015/05/04 15:08:07, bsalomon wrote:
> override?

This is the base-class, introducing these methods. They are not "empty" as PDF
and Raster want the dumb convert-to-raster behavior.

[reed1, 2015-05-04 15:31:21]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-05-04 15:31:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1118823004/40001

[commit-bot: I haz the power, 2015-05-04 15:32:10]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f603fb3d0e5fa57c3f228d66945bef198b001135

[reed1, 2015-05-04 16:00:15]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1122803002/ by reed@google.com.

The reason for reverting is: need to make serialization work for pictures, now
that images are "real".