Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1118823003: Extract Signature from src/compiler/machine-type.h to src/signature.h (Closed)

Created:
5 years, 7 months ago by titzer
Modified:
5 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Extract Signature from src/compiler/machine-type.h to src/signature.h R=bmeurer@chromium.org BUG= Committed: https://crrev.com/acdb5336a97eda5f0c4028e99c05107de4ff0c41 Cr-Commit-Position: refs/heads/master@{#28191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -64 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-type.h View 2 chunks +1 line, -64 lines 0 comments Download
A src/signature.h View 1 chunk +80 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years, 7 months ago (2015-05-04 09:44:16 UTC) #1
Benedikt Meurer
lgtm
5 years, 7 months ago (2015-05-04 09:45:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118823003/1
5 years, 7 months ago (2015-05-04 09:45:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-04 10:11:55 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 10:12:06 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/acdb5336a97eda5f0c4028e99c05107de4ff0c41
Cr-Commit-Position: refs/heads/master@{#28191}

Powered by Google App Engine
This is Rietveld 408576698