Chrome security team IPC message owners.

Chrome security team IPC message owners.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166956

[jam, 2014-01-13 17:04:40]

https://codereview.chromium.org/11188047/diff/2001/android_webview/common/OWNERS
File android_webview/common/OWNERS (right):

https://codereview.chromium.org/11188047/diff/2001/android_webview/common/OWN...
android_webview/common/OWNERS:2: # new sandbox escapes.
since android_webview runs single-process mode, there are no sandbox escapes
here. not sure why security review is needed for these IPCs?

[Tom Sepez, 2014-01-13 17:56:40]

Removing the security review seems reasonable to me.

[jam, 2014-01-13 18:25:22]

https://codereview.chromium.org/11188047/diff/25001/android_webview/common/OW...
File android_webview/common/OWNERS (right):

https://codereview.chromium.org/11188047/diff/25001/android_webview/common/OW...
android_webview/common/OWNERS:2: # don't require a security review because
anrdoid_webview is single-process
nit: android_webview

[jam, 2014-01-13 18:25:35]

lgtm

[Chris Evans, 2014-01-13 19:17:20]

On 2014/01/13 18:25:35, jam wrote:
> lgtm

I don't know enough about android_webview to comment. Perhaps defer to @palmer?

[Chris Evans, 2014-01-13 19:17:49]

On 2014/01/13 19:17:20, Chris Evans wrote:
> On 2014/01/13 18:25:35, jam wrote:
> > lgtm
> 
> I don't know enough about android_webview to comment. Perhaps defer to
@palmer?

[+palmer]

[benm (inactive), 2014-01-13 19:35:34]

On 2014/01/13 19:17:49, Chris Evans wrote:
> On 2014/01/13 19:17:20, Chris Evans wrote:
> > On 2014/01/13 18:25:35, jam wrote:
> > > lgtm
> > 
> > I don't know enough about android_webview to comment. Perhaps defer to
> @palmer?
> 
> [+palmer]

WebView is single process at the moment, but we may investigate moving to a
multi-process model in the future. If it's not too much of a burden, I'd like to
keep security team in the loop on messages to make sure we don't do anything too
crazy ;-)

Thanks

[Tom Sepez, 2014-01-13 19:41:49]

On 2014/01/13 19:35:34, benm wrote:
> On 2014/01/13 19:17:49, Chris Evans wrote:
> > On 2014/01/13 19:17:20, Chris Evans wrote:
> > > On 2014/01/13 18:25:35, jam wrote:
> > > > lgtm
> > > 
> > > I don't know enough about android_webview to comment. Perhaps defer to
> > @palmer?
> > 
> > [+palmer]
> 
> WebView is single process at the moment, but we may investigate moving to a
> multi-process model in the future. If it's not too much of a burden, I'd like
to
> keep security team in the loop on messages to make sure we don't do anything
too
> crazy ;-)
> 
> Thanks

Right.  Will restore per your request.

[benm (inactive), 2014-01-13 19:55:28]

thanks!


On 13 January 2014 11:41, <tsepez@chromium.org> wrote:

> On 2014/01/13 19:35:34, benm wrote:
>
>> On 2014/01/13 19:17:49, Chris Evans wrote:
>> > On 2014/01/13 19:17:20, Chris Evans wrote:
>> > > On 2014/01/13 18:25:35, jam wrote:
>> > > > lgtm
>> > >
>> > > I don't know enough about android_webview to comment. Perhaps defer to
>> > @palmer?
>> >
>> > [+palmer]
>>
>
>  WebView is single process at the moment, but we may investigate moving to
>> a
>> multi-process model in the future. If it's not too much of a burden, I'd
>> like
>>
> to
>
>> keep security team in the loop on messages to make sure we don't do
>> anything
>>
> too
>
>> crazy ;-)
>>
>
>  Thanks
>>
>
> Right.  Will restore per your request.
>
> https://codereview.chromium.org/11188047/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.