Introduce Android variants of ChromeGeolocationPermissionContext, GeolocationConfirmInfoBarDelegate

chrome/browser/geolocation/geolocation_infobar_queue_controller_android.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_GEOLOCATION_GEOLOCATION_INFOBAR_QUEUE_CONTROLLER_ANDROID_H_
+#define CHROME_BROWSER_GEOLOCATION_GEOLOCATION_INFOBAR_QUEUE_CONTROLLER_ANDROID_H_
+
+#include "chrome/browser/geolocation/geolocation_infobar_queue_controller.h"
+
+// Android-specific geolocation infobar queue controller. As with
+// GeolocationInfoBarQueueController, this class is owned by
+// ChromeGeolocationPermissionContextAndroid.
+class GeolocationInfoBarQueueControllerAndroid
+    : public GeolocationInfoBarQueueController {

[bulach, 2012/10/17 13:17:38]

the queue controller class is pretty heavy weight and does a lot of stuff..
in here, it seems we only need to CreateInfoBarDelegate, but nothing else from
the base class, that is, the method itself only requires the params that are
passed to it.

how about this:
class GeolocationConfirmInfoBarDelegateFactory {
  // Creates a platform-specific geolocation ConfirmInfoBarDelegate.
  static GeolocationConfirmInfoBarDelegate* create(...);
};

the in the .cc file, we just have a simple ifdef to create an instance of the
specific class... how does it sound?

reason: when there's real platform-specific behavior change, such as in the
permission context, it makes sense to to split into a base class and have
different implementations.
but in this case, it's just a matter of creating the right class, so the
overhead is probably not worth it.. wdyt?

[John Knottenbelt, 2012/10/17 13:39:41]

Thanks, Marcus - yes I agree, this sounds simpler indeed.

On 2012/10/17 13:17:38, bulach wrote:

[Ramya, 2012/10/17 21:43:31]

Done.

+
+ public:
+  explicit GeolocationInfoBarQueueControllerAndroid(
+      Profile* profile);
+
+ private:

[bulach, 2012/10/17 13:17:38]

nit:
  // GeolocationInfoBarQueueController

+  virtual GeolocationConfirmInfoBarDelegate* CreateInfoBarDelegate(
+      InfoBarTabHelper* infobar_helper,
+      GeolocationInfoBarQueueController* controller,
+      int render_process_id,
+      int render_view_id,
+      int bridge_id,
+      const GURL& requesting_frame_url,
+      const std::string& display_languages) OVERRIDE;

[bulach, 2012/10/17 13:17:38]

nit:

\n
DISALLOW_COPY_AND_ASSIGN(GeolocationInfoBarQueueControllerAndroid);

+};
+
+#endif  // CHROME_BROWSER_GEOLOCATION_GEOLOCATION_INFOBAR_QUEUE_CONTROLLER_ANDROID_H__