Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3115)

Unified Diff: base/mac/scoped_mach_port.cc

Issue 11188003: Fix some potential Mach port leaks from mach_host_self using a new ScopedMachPort class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/mac/scoped_mach_port.cc
diff --git a/base/mac/scoped_mach_port.cc b/base/mac/scoped_mach_port.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ef21fbe899e5f22cdb17039c6520d8e45310fa8d
--- /dev/null
+++ b/base/mac/scoped_mach_port.cc
@@ -0,0 +1,32 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/mac/scoped_mach_port.h"
+
+namespace base {
+namespace mac {
+
+ScopedMachPort::ScopedMachPort() : port_(MACH_PORT_NULL) {
+}
+
+ScopedMachPort::ScopedMachPort(mach_port_t port) : port_(port) {
+}
+
+ScopedMachPort::~ScopedMachPort() {
+ if (port_ != MACH_PORT_NULL) {
+ mach_port_deallocate(mach_task_self(), port_);
+ port_ = MACH_PORT_NULL;
Mark Mentovai 2012/10/16 16:34:28 Not strictly necessary for the destructor.
Robert Sesek 2012/10/16 16:40:23 Done.
+ }
+}
+
+ScopedMachPort::operator mach_port_t() const {
+ return port_;
+}
+
+mach_port_t ScopedMachPort::get() const {
+ return port_;
+}
+
+} // namespace mac
+} // namespace base

Powered by Google App Engine
This is Rietveld 408576698