Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1118773004: [chrome/browser/chromeos/policy] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome/browser module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/b71a6bbc63980de5f5d5309754b24fd3584c29f8 Cr-Commit-Position: refs/heads/master@{#328150}

Patch Set 1 #

Patch Set 2 : fixed build break #

Patch Set 3 : Fixed Review Comments #

Total comments: 6

Patch Set 4 : Fixed Review Comments->2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -71 lines) Patch
M chrome/browser/chromeos/policy/auto_enrollment_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_manager_base.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc View 2 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 5 chunks +10 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/policy/policy_cert_verifier_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_policy_disk_cache.cc View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/user_policy_token_loader.cc View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
Pranay
PTAL Thanks
5 years, 7 months ago (2015-05-04 10:28:59 UTC) #2
Mattias Nissler (ping if slow)
LGTM
5 years, 7 months ago (2015-05-04 10:33:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118773004/1
5 years, 7 months ago (2015-05-04 10:34:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/33699)
5 years, 7 months ago (2015-05-04 11:07:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118773004/20001
5 years, 7 months ago (2015-05-04 11:18:58 UTC) #10
Mattias Nissler (ping if slow)
Stopping commit. AFAICT, you tried to "repair" the build breakage by just dropping the cloud_external_data_manager_base.cc ...
5 years, 7 months ago (2015-05-04 11:29:48 UTC) #12
Pranay
Hi Mattias, Yes, your review is absolutely correct :) I have updated the patch, PTAL ...
5 years, 7 months ago (2015-05-04 12:38:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118773004/40001
5 years, 7 months ago (2015-05-04 13:14:16 UTC) #16
Mattias Nissler (ping if slow)
Stopping commit again, see inline comments. https://codereview.chromium.org/1118773004/diff/40001/chrome/browser/chromeos/policy/cloud_external_data_manager_base.h File chrome/browser/chromeos/policy/cloud_external_data_manager_base.h (right): https://codereview.chromium.org/1118773004/diff/40001/chrome/browser/chromeos/policy/cloud_external_data_manager_base.h#newcode12 chrome/browser/chromeos/policy/cloud_external_data_manager_base.h:12: #include "base/single_thread_task_runner.h" This ...
5 years, 7 months ago (2015-05-04 13:25:17 UTC) #18
Pranay
Done https://codereview.chromium.org/1118773004/diff/40001/chrome/browser/chromeos/policy/cloud_external_data_manager_base.h File chrome/browser/chromeos/policy/cloud_external_data_manager_base.h (right): https://codereview.chromium.org/1118773004/diff/40001/chrome/browser/chromeos/policy/cloud_external_data_manager_base.h#newcode12 chrome/browser/chromeos/policy/cloud_external_data_manager_base.h:12: #include "base/single_thread_task_runner.h" On 2015/05/04 13:25:17, Mattias Nissler wrote: ...
5 years, 7 months ago (2015-05-04 13:57:12 UTC) #19
Mattias Nissler (ping if slow)
LGTM
5 years, 7 months ago (2015-05-04 13:59:12 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118773004/60001
5 years, 7 months ago (2015-05-04 17:29:06 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-04 18:08:26 UTC) #23
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 18:10:32 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b71a6bbc63980de5f5d5309754b24fd3584c29f8
Cr-Commit-Position: refs/heads/master@{#328150}

Powered by Google App Engine
This is Rietveld 408576698